From: Deborah G. <gol...@ap...> - 2005-12-09 23:47:44
|
In my work on the integration of dictionary support into RuleBasedBreakIterator, I've noticed that the (@internal) handleNext (void) member function does not add a lot. It's protected and intended for override by subclasses, but it seems like the same effect could be had by moving the implementation of handleNext(void) into next(void), and having internal clients that call handleNext (void) call next(void). This would cut out one layer of virtual function call in a heavily used path. Currently the code looks like this: int32_t RuleBasedBreakIterator::next(void) { return handleNext(); } int32_t RuleBasedBreakIterator::handleNext() { return handleNext(fData->fForwardTable); } Both functions are virtual, and this seems redundant. Any comments? Deborah |