Re: [icu-design] ICU API proposal: Add const to UReplaceableCallbacks* params in utrans API

[Peter E. <pe...@ap...>]

This was approved in the ICU TC meeting today, as originally proposed.
- Peter E

> On Feb 7, 2018, at 10:05 PM, Mark Davis ☕️ <ma...@ma...> wrote:
> 
> Sgtm
> 
> {phone}
> 
> On Feb 8, 2018 01:45, "Peter Edberg" <pe...@ap... <mailto:pe...@ap...>> wrote:
> Dear ICU team & users,
> 
> I would like to propose the following API change for: ICU 61
> Please provide feedback by: next Tuesday, 2018-02-13
> Designated API reviewer: Andy
> Ticket: http://bugs.icu-project.org/trac/ticket/12907 <http://bugs.icu-project.org/trac/ticket/12907> 
> 
> utrans.h includes the following functions:
> 
> void
> utrans_trans(const UTransliterator* trans,
>              UReplaceable* rep,
>              UReplaceableCallbacks* repFunc,
>              int32_t start,
>              int32_t* limit,
>              UErrorCode* status);
> 
> void
> utrans_transIncremental(const UTransliterator* trans,
>                         UReplaceable* rep,
>                         UReplaceableCallbacks* repFunc,
>                         UTransPosition* pos,
>                         UErrorCode* status);
> 
> The proposal is to change "UReplaceableCallbacks* repFunc" in each of these to "const UReplaceableCallbacks* repFunc"; repFunc is a pointer to a caller-supplied list of function pointers that manipulate the text being transliterated, and the utrans functions do not (and should not) change those pointers. Adding const should be a safe change and will make these functions easier to use in certain contexts.
> 
> - Peter E
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot <http://sdm.link/slashdot>
> _______________________________________________
> icu-design mailing list
> icu...@li... <mailto:icu...@li...>
> To Un/Subscribe: https://lists.sourceforge.net/lists/listinfo/icu-design <https://lists.sourceforge.net/lists/listinfo/icu-design>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
> icu-design mailing list
> icu...@li...
> To Un/Subscribe: https://lists.sourceforge.net/lists/listinfo/icu-design