Re: [icu-support] Request for patch review

[Roberto C. S. <ro...@co...>]

On Thu, Jul 07, 2016 at 09:10:32AM -0700, Steven Loomis wrote:
> Hello,
>  1. *for all patches contributed to ICU* please follow the link at the bottom http://bugs.icu-project.org/trac/ticket/12276#cla  and ensure you’ve signed the CLA.
>  
>  2. I own the ticket, but had not responded to this yet. 
> 
>  3. The patches look good. The “signed overflow” in the compile options was unexpected and may need some evaluation. (I wrote and/or reviewed the OpenJDK side patches)
> 
> 

Hi Steven,

Thanks for reviewing the patches.  If you think that the patches might
be accepted upstream, I'd be happy to complete the CLA.

For the moment, my priority was to get a review from someone more
knowledgable so that I could feel comfortable uploading the security
update to Debian oldstable without too much risk of causing a
regression.  I wasn't sure that the patches would even be needed
upstream.

Regards,

-Roberto


-- 
Roberto C. Sánchez
http://people.connexer.com/~roberto
http://www.connexer.com