iaxclient-devel — Development Discussion List

Re: [Iaxclient-devel] sched_priority

[Peter G. <jpg...@gm...>]

Hi Jean-Denis,

Thank you for testing the patch. I have committed all of these changes
to iaxclient/trunk (rev 1448).

And thank you for reporting this problem.

Pete

On Wed, Jul 2, 2008 at 2:42 PM, Jean-Denis Girard <jd....@sy...> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> Peter Grayson wrote:
> | Jean-Denis,
> |
> | Thank you for your analysis of this problem. It was very helpful.
> |
> | Please apply the attached patch and let me know if it still resolves
> | the problem you're observing.
>
> Yes, problem is resolved by your patch. I've tested on both systems, it
> does work fine.
>
> |
> | This patch fixes addresses a problem I saw in your previous patch
> | where the priority of the watchdog thread might become lower than the
> | priority of the canary thread. If that happened, the whole scheme
> | would be bogus because the watchdog would never wake up to check the
> | canary.
>
> Ok.
>
> |
> | This patch also addresses a memory leak of the prioboost structure and
> | some style issues in unixfuncs.c. I apologize for not splitting the
> | patch.
>
> Thanks for your work. iaxclient-2.1 gives very good results, sound
> quality is much improved from the old version I was using.
>
>
> Regards,
> - --
> Jean-Denis Girard
>
> SysNux                  Systèmes  Linux  en Polynésie française
> http://www.sysnux.pf/   Tél: +689 50 10 40 / GSM: +689 79 75 27
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Mandriva - http://enigmail.mozdev.org
>
> iEYEARECAAYFAkhrzCIACgkQuu7Rv+oOo/ixRQCgm3rlO2pP85pdLxH88tPs920R
> fz0An3rZYAcveroQjehooQyEqzs35kH7
> =2iZ/
> -----END PGP SIGNATURE-----
>

Re: [Iaxclient-devel] sched_priority

[Jean-Denis G. <jd....@sy...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Peter Grayson wrote:
| Jean-Denis,
|
| Thank you for your analysis of this problem. It was very helpful.
|
| Please apply the attached patch and let me know if it still resolves
| the problem you're observing.

Yes, problem is resolved by your patch. I've tested on both systems, it
does work fine.

|
| This patch fixes addresses a problem I saw in your previous patch
| where the priority of the watchdog thread might become lower than the
| priority of the canary thread. If that happened, the whole scheme
| would be bogus because the watchdog would never wake up to check the
| canary.

Ok.

|
| This patch also addresses a memory leak of the prioboost structure and
| some style issues in unixfuncs.c. I apologize for not splitting the
| patch.

Thanks for your work. iaxclient-2.1 gives very good results, sound
quality is much improved from the old version I was using.


Regards,
- --
Jean-Denis Girard

SysNux                  Systèmes  Linux  en Polynésie française
http://www.sysnux.pf/   Tél: +689 50 10 40 / GSM: +689 79 75 27
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mandriva - http://enigmail.mozdev.org

iEYEARECAAYFAkhrzCIACgkQuu7Rv+oOo/ixRQCgm3rlO2pP85pdLxH88tPs920R
fz0An3rZYAcveroQjehooQyEqzs35kH7
=2iZ/
-----END PGP SIGNATURE-----

Re: [Iaxclient-devel] sched_priority

[Peter G. <jpg...@gm...>]

Jean-Denis,

Thank you for your analysis of this problem. It was very helpful.

Please apply the attached patch and let me know if it still resolves
the problem you're observing.

This patch fixes addresses a problem I saw in your previous patch
where the priority of the watchdog thread might become lower than the
priority of the canary thread. If that happened, the whole scheme
would be bogus because the watchdog would never wake up to check the
canary.

This patch also addresses a memory leak of the prioboost structure and
some style issues in unixfuncs.c. I apologize for not splitting the
patch.

Thanks,
Pete

Re: [Iaxclient-devel] sched_priority

[Andrea S. <si...@op...>]

Jean-Denis Girard wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> I've done some more testing, and I think I have a complete explanation.

perfect! I love when strange phenomena get their explanation ;)

> On the system where my patch is needed, the user I run as belongs to
> group audio, and /etc/security/limits.conf shows:
> 	@audio          -       rtprio           50
> When iaxclient is initialized iaxci_prioboostbegin sets priority to 49
> (sched_get_priority_min returns 0, sched_get_priority_max 99) without
> error. Then StartWatchDog is called, which in turn calls WatchDogProc.
> It tries to set priority to 53, which fails because of security limit.
> If I change the rtprio limit to 60 for group audio, then setting
> priority to 53 works fine.
> On the other system, user does not belong to group audio, so it cannot
> set real-time priority, StartWatchDog and WatchDogProc are never called,
> then iaxclient works fine.

it sounds like a good explanation

> I think my patch does address a real problem, at least for Mandriva
> users (and probably others), which won't be able to use iaxclient based
> applications out of the box.

I do agree!

by the way I've just checked limits.conf setting on my ubuntu system (7.10 aka gutsy)
and I've discovered that each line on that file is commented.... strange I wonder if
the use other way to enforce the security policies that mandriva use to set through
limits.conf

Andrea

Re: [Iaxclient-devel] sched_priority

[Jean-Denis G. <jd....@sy...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


I've done some more testing, and I think I have a complete explanation.

On the system where my patch is needed, the user I run as belongs to
group audio, and /etc/security/limits.conf shows:
	@audio          -       rtprio           50
When iaxclient is initialized iaxci_prioboostbegin sets priority to 49
(sched_get_priority_min returns 0, sched_get_priority_max 99) without
error. Then StartWatchDog is called, which in turn calls WatchDogProc.
It tries to set priority to 53, which fails because of security limit.
If I change the rtprio limit to 60 for group audio, then setting
priority to 53 works fine.

On the other system, user does not belong to group audio, so it cannot
set real-time priority, StartWatchDog and WatchDogProc are never called,
then iaxclient works fine.

I think my patch does address a real problem, at least for Mandriva
users (and probably others), which won't be able to use iaxclient based
applications out of the box.


Andrea Suisani wrote:
| Hi Jean-Denis
|
| [cut]
|
|> No, it's failing in a more subtle way: when placing a call, it seems
|> that IAX events are not received correctly. For example, here is the
|> trace from my application (MozPhone, see http://moziax.mozdev.org/) when
|> a call is successfully placed (with my patched iaxclient-2.1beta3):
|> - ------------
|> iaxc_initialize OK, 2 lines
|> WatchDogProc: cannot set watch dog priority 53 !
|> WatchDogProc: cannot set watch dog priority 52 !
|> WatchDogProc: cannot set watch dog priority 51 !
|
| anyhow there's something that makes priority switching
| somekind problmeatic, am I right? you've to decrease
| priority 3 times before getting it set.
|
|
|> Looking for Plantronics cs60usb...
|
| [cut]
|
|> warning: The VAD has been replaced by a hack pending a complete rewrite
| [cut]
|> warning: The VAD has been replaced by a hack pending a complete rewrite
|
| why you need to load speex codec library twice?
|
|> As you can see IAX events are received as expected, call is successful.
|> Now here is what I get with original iaxclient-2.1beta3:
|> - ---------------------
|> iaxc_initialize OK, 2 lines
|
| [cut]
|
|> As you can see, IAX state event accepted is never received.
|
| I see :/
|
| [cut]
|
|> Both systems where 2.6.25.x kernels, but one is 64bits-smp (base distro
|> is Mandriva-2008.1-64), the other is 32 bits (Mandriva cooker-32).
|
| Which one fails without the patch?
|
| Are those plain vanilla kernel (fetched from kernel org) or are they
| provided by rmps
| (yum)?
|
| I'm not very familiar with Mandriva's world, though it seems to me that
| coocker is the dev branch, isn't it? so maybe it could be something
| in the cooker toolchain that makes things a little bit "unstable".
|
|
|>>> I already reported same problem long ago, but maybe I'm the only one
|>>> affected by this...
|>>>
http://sourceforge.net/mailarchive/message.php?msg_id=4366C3DF.2010308%40sysnux.pf

|>>>
|>>>
|>> reading through this thread I've just noted you said
|>> that also portaudio/pa_unix_oss/pa_unix.c has to be changed.
|>> is this editing still needed?
|>
|> No, it is no longer needed.
|>
|> I know priorities permissions can be modified on Linux according to
|> limits.conf, but I think this is a real problem for Linux users, that my
|> proposed patch can solve.
|>
|> I just downloaded / tested binary iaxcomm-1.2.0: it fails to run as
|> normal user because it cannot set the watchdog priority, and runs fine
|> as root.
|
| Any chance to test this on a different machine with a different
| linux flavours? (cause I've never experienced such a bug both on
| Debian (etch/4.0)and Ubuntu (>=7.04))
|
| Andrea
|


Thanks,
- --
Jean-Denis Girard

SysNux                  Systèmes  Linux  en Polynésie française
http://www.sysnux.pf/   Tél: +689 50 10 40 / GSM: +689 79 75 27
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mandriva - http://enigmail.mozdev.org

iEYEARECAAYFAkhpRUMACgkQuu7Rv+oOo/jeEwCffKtr8xZaJFNtgtJ/vV/818C+
kRAAniWMEVArlypABsnVAd3oTSmlvWmo
=kv6Q
-----END PGP SIGNATURE-----

Re: [Iaxclient-devel] sched_priority

[Andrea S. <si...@op...>]

Hi Jean-Denis

[cut]

> No, it's failing in a more subtle way: when placing a call, it seems
> that IAX events are not received correctly. For example, here is the
> trace from my application (MozPhone, see http://moziax.mozdev.org/) when
> a call is successfully placed (with my patched iaxclient-2.1beta3):
> - ------------
> iaxc_initialize OK, 2 lines
> WatchDogProc: cannot set watch dog priority 53 !
> WatchDogProc: cannot set watch dog priority 52 !
> WatchDogProc: cannot set watch dog priority 51 !

anyhow there's something that makes priority switching
somekind problmeatic, am I right? you've to decrease
priority 3 times before getting it set.


> Looking for Plantronics cs60usb...

[cut]

> warning: The VAD has been replaced by a hack pending a complete rewrite
[cut]
> warning: The VAD has been replaced by a hack pending a complete rewrite

why you need to load speex codec library twice?

> As you can see IAX events are received as expected, call is successful.
> Now here is what I get with original iaxclient-2.1beta3:
> - ---------------------
> iaxc_initialize OK, 2 lines

[cut]

> As you can see, IAX state event accepted is never received.

I see :/

[cut]

> Both systems where 2.6.25.x kernels, but one is 64bits-smp (base distro
> is Mandriva-2008.1-64), the other is 32 bits (Mandriva cooker-32).

Which one fails without the patch?

Are those plain vanilla kernel (fetched from kernel org) or are they provided by rmps
(yum)?

I'm not very familiar with Mandriva's world, though it seems to me that
coocker is the dev branch, isn't it? so maybe it could be something
in the cooker toolchain that makes things a little bit "unstable".


>>> I already reported same problem long ago, but maybe I'm the only one
>>> affected by this...
>>> http://sourceforge.net/mailarchive/message.php?msg_id=4366C3DF.2010308%40sysnux.pf
>>>
>> reading through this thread I've just noted you said
>> that also portaudio/pa_unix_oss/pa_unix.c has to be changed.
>> is this editing still needed?
> 
> No, it is no longer needed.
> 
> I know priorities permissions can be modified on Linux according to
> limits.conf, but I think this is a real problem for Linux users, that my
> proposed patch can solve.
> 
> I just downloaded / tested binary iaxcomm-1.2.0: it fails to run as
> normal user because it cannot set the watchdog priority, and runs fine
> as root.

Any chance to test this on a different machine with a different
linux flavours? (cause I've never experienced such a bug both on
Debian (etch/4.0)and Ubuntu (>=7.04))

Andrea

Re: [Iaxclient-devel] sched_priority

[Jean-Denis G. <jd....@sy...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Andrea,

Andrea Suisani a écrit :
> Hi, Jean-Denis
> 
> Jean-Denis Girard wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi,
>>
>> I recently moved to latest versions (2.1beta3 and trunk), and though it
>> worked very well on first test system (much improved sound quality
>> comparing to old versions), it didn't work on another system. Both
> 
> what does "didn't work" mean? application seg-faulted or whatever?

No, it's failing in a more subtle way: when placing a call, it seems
that IAX events are not received correctly. For example, here is the
trace from my application (MozPhone, see http://moziax.mozdev.org/) when
a call is successfully placed (with my patched iaxclient-2.1beta3):
- ------------
iaxc_initialize OK, 2 lines
WatchDogProc: cannot set watch dog priority 53 !
WatchDogProc: cannot set watch dog priority 52 !
WatchDogProc: cannot set watch dog priority 51 !
Looking for Plantronics cs60usb...
Plantronics CS60-USB found at /dev/hiddev0
cs60init: thread 0 running.
......
Calling xxx:xx...@xx.../196...
Ignoring text event t,-1,2,Originating an audio only call
t,-1,2,Originating an audio only call
New STATE_EV 38 for call 0
outgoing=4, ringing=0, complete=0, selected=32, busy=0, active=2
State event: s,0,selected,
STATE_EV => 0 not accepted yet...
State event: s,0,not_accepted,196
warning: The VAD has been replaced by a hack pending a complete rewrite
Ignoring text event t,-1,1,Call 0 accepted
t,-1,1,Call 0 accepted
New STATE_EV 54 for call 0
outgoing=4, ringing=0, complete=16, selected=32, busy=0, active=2
State event: s,0,selected,
State event: s,0,active,196
cs60: status 5
Ignoring text event t,-1,1,Call 0 answered
No RTT  Rjit    Rlos%   RlosC   Rpkts   Rdel    Rdrop   Rooo    Ljit
Llos%   LlosC      Lpkts
   Ldel    Ldrop   Looo
0: 66   0       0       0       1       40      0       0       32
0       0 102      105
   0       0
warning: The VAD has been replaced by a hack pending a complete rewrite
Ignoring text event t,-1,1,Hanging up call 0
t,-1,1,Hanging up call 0
New STATE_EV 0 for call 0
outgoing=0, ringing=0, complete=0, selected=0, busy=0, active=0
STATE_EV => 0 NOT_active
- ---------------------

As you can see IAX events are received as expected, call is successful.
Now here is what I get with original iaxclient-2.1beta3:
- ---------------------
iaxc_initialize OK, 2 lines
WatchDogProc: cannot set watch dog priority!
WatchDogProc: killing hung audio thread!
Looking for Plantronics cs60usb...
Plantronics CS60-USB found at /dev/hiddev0
cs60init: thread 0 running.
......
Calling xxx:xx...@xx.../196...
Ignoring text event t,-1,2,Originating an audio only call
t,-1,2,Originating an audio only call
New STATE_EV 38 for call 0
outgoing=4, ringing=0, complete=0, selected=32, busy=0, active=2
State event: s,0,selected,
STATE_EV => 0 not accepted yet...
State event: s,0,not_accepted,196
Ignoring text event t,-1,1,Hanging up call 0
t,-1,1,Hanging up call 0
New STATE_EV 0 for call 0
outgoing=0, ringing=0, complete=0, selected=0, busy=0, active=0
STATE_EV => 0 NOT_active
cs60: status 1
State event: s,0,not_active,
- ---------

As you can see, IAX state event accepted is never received.

> 
>> systems are Linux, and I finally found that the problem was related to
>> setting the priority in unixfuncs.c: requested priority (+4) cannot be
>> set for a normal user (it's working for root of course).
> 
> just for curiosity's sake, which kernel runs each of the involved systems?

Both systems where 2.6.25.x kernels, but one is 64bits-smp (base distro
is Mandriva-2008.1-64), the other is 32 bits (Mandriva cooker-32).

> 
>> I already reported same problem long ago, but maybe I'm the only one
>> affected by this...
>> http://sourceforge.net/mailarchive/message.php?msg_id=4366C3DF.2010308%40sysnux.pf
>>
> 
> reading through this thread I've just noted you said
> that also portaudio/pa_unix_oss/pa_unix.c has to be changed.
> is this editing still needed?

No, it is no longer needed.

I know priorities permissions can be modified on Linux according to
limits.conf, but I think this is a real problem for Linux users, that my
proposed patch can solve.

I just downloaded / tested binary iaxcomm-1.2.0: it fails to run as
normal user because it cannot set the watchdog priority, and runs fine
as root.


Thanks,
- --
Jean-Denis Girard

SysNux                  Systèmes  Linux  en Polynésie française
http://www.sysnux.pf/   Tél: +689 50 10 40 / GSM: +689 79 75 27
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mandriva - http://enigmail.mozdev.org

iEYEARECAAYFAkhlI9kACgkQuu7Rv+oOo/h9hwCgmulmol9vb0fYSoVtJgmgFiu3
N5sAn0alXSVMkPnX5MlFJlZHKJTn/t3q
=PI5n
-----END PGP SIGNATURE-----

Re: [Iaxclient-devel] handling multiple calls

[Andrea S. <si...@op...>]

Hi Peter, Jerimy

Peter Grayson wrote:
> Hi Jeremy,

[cut]

> Despite iaxclient having the concept of handling multiple calls,
> iaxclient offers poor semantics for dealing with multiple calls. The
> "protocol" is that you can use iaxc_select_call() to switch which of
> the multiple connected calls is active. It is only the active call
> that audio is sent to or received from -- there is no way to "mix" two
> calls.

ok, but is there any function (API) in iaxclient that returns
a list of established calls? as far as I can see there's
only iaxc_selected_call() that return actual selected call.
am I missing something?

(yes of course at application level I could keep track
of established calls...)

[cut]

Andrea

Re: [Iaxclient-devel] sched_priority

[Andrea S. <si...@op...>]

Hi, Jean-Denis

Jean-Denis Girard wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
> I recently moved to latest versions (2.1beta3 and trunk), and though it
> worked very well on first test system (much improved sound quality
> comparing to old versions), it didn't work on another system. Both

what does "didn't work" mean? application seg-faulted or whatever?

> systems are Linux, and I finally found that the problem was related to
> setting the priority in unixfuncs.c: requested priority (+4) cannot be
> set for a normal user (it's working for root of course).

just for curiosity's sake, which kernel runs each of the involved systems?

> I already reported same problem long ago, but maybe I'm the only one
> affected by this...
> http://sourceforge.net/mailarchive/message.php?msg_id=4366C3DF.2010308%40sysnux.pf

reading through this thread I've just noted you said
that also portaudio/pa_unix_oss/pa_unix.c has to be changed.
is this editing still needed?

Andrea

Re: [Iaxclient-devel] crash in iax_event_free on mac

[Dennis C. <DCh...@pi...>]

Hi Peter,

Yes these could be the culprits. What you say seems to imply that the  
iax_get_event clause under discussion ought to be checking if frame or  
event is null before using it. But the specific issue I am seeing is  
that the frame->data is not null but has already been freed. On OS X,  
the MallocScribble debug utility marks freed pointers so you can see  
them in your symbolic debugger--that is what I am using.

This is pretty reproducible so if you want me to investigate anything  
specific let me know.

Dennis
On Jun 25, 2008, at 12:29 PM, Peter Grayson wrote:

> On Wed, Jun 25, 2008 at 11:12 AM, Dennis Christopher
> <DCh...@pi...> wrote:
>> HI Peter,
>> I am working with 2.1beta3.
>>
>> Sorry I got two variables mixed together. The iax_get_event() code  
>> is using
>> an already freed ptr in the clause I mentioned thru the fh variable.
>> fh is assigned frame->data, which is the already freed ptr. the  
>> data member
>> in turn comes from cur->frame with cur coming
>> from iax_get_sched(). I noticed that when this happens that cur- 
>> >event is
>> null.
>
> One thing to note is that the iax_sched object acts as a sort of union
> holding either an event, a frame, or a function. These are all
> schedulable objects. It is expected that only one of event, frame, or
> func will be non-null.
>
> That said, I think I may see the problem you are alluding to. What I
> see is that there are two ways that iax_frame objects are allocated.
> In iax_frame_new(), there is a single allocation for both the struct
> iax_frame and it's data; in iax_reliable_xmit() there are separate
> allocations for the struct iax_frame and the data.
>
> This leads to the problem where the frame->data is sometimes free()ed
> separately from the frame data itself. I suspect that this may be what
> is triggering whatever diagnostic you are looking at.
>
> Another issue that I see is that there are several places where
> iax_sched objects are free()ed without freeing the event and/or frame
> objects they point to. I see this in iax_sched_del(),
> iax_sched_vnak(), and destroy_session().
>
> I will be taking a closer look at these issues.
>
> Do these issues seem like they might be related to the problem you are
> attempting to point out? What tools are you using to get the
> diagnostic about already freed pointers?
>
> Thanks,
> Pete

Re: [Iaxclient-devel] crash in iax_event_free on mac

[Peter G. <jpg...@gm...>]

On Wed, Jun 25, 2008 at 11:12 AM, Dennis Christopher
<DCh...@pi...> wrote:
> HI Peter,
> I am working with 2.1beta3.
>
> Sorry I got two variables mixed together. The iax_get_event() code is using
> an already freed ptr in the clause I mentioned thru the fh variable.
> fh is assigned frame->data, which is the already freed ptr. the data member
> in turn comes from cur->frame with cur coming
> from iax_get_sched(). I noticed that when this happens that cur->event is
> null.

One thing to note is that the iax_sched object acts as a sort of union
holding either an event, a frame, or a function. These are all
schedulable objects. It is expected that only one of event, frame, or
func will be non-null.

That said, I think I may see the problem you are alluding to. What I
see is that there are two ways that iax_frame objects are allocated.
In iax_frame_new(), there is a single allocation for both the struct
iax_frame and it's data; in iax_reliable_xmit() there are separate
allocations for the struct iax_frame and the data.

This leads to the problem where the frame->data is sometimes free()ed
separately from the frame data itself. I suspect that this may be what
is triggering whatever diagnostic you are looking at.

Another issue that I see is that there are several places where
iax_sched objects are free()ed without freeing the event and/or frame
objects they point to. I see this in iax_sched_del(),
iax_sched_vnak(), and destroy_session().

I will be taking a closer look at these issues.

Do these issues seem like they might be related to the problem you are
attempting to point out? What tools are you using to get the
diagnostic about already freed pointers?

Thanks,
Pete

Re: [Iaxclient-devel] crash in iax_event_free on mac

[Dennis C. <DCh...@pi...>]

HI Peter,

I am working with 2.1beta3.


Sorry I got two variables mixed together. The iax_get_event() code is  
using an already freed ptr in the clause I mentioned thru the fh  
variable.
fh is assigned frame->data, which is the already freed ptr. the data  
member in turn comes from cur->frame with cur coming
from iax_get_sched(). I noticed that when this happens that cur- 
 >event is null.

Dennis

On 25-Jun-08, at 10:26 AM, Peter Grayson wrote:

> Hi Dennis,
>
> On Tue, Jun 24, 2008 at 9:14 AM, Dennis Christopher
> <dch...@pi...> wrote:
>> Peter,
>> I have set an environment variable to detect re-use of freed  
>> pointers and I
>> can see a case in iax_get_event (near  " Decrement remaining  
>> retries ") that
>> goes wrong because it references an event returned from  
>> iax_get_sched()
>> whose event ptr is null. In the code generally this seems possible  
>> because
>> freed ptrs are not
>> set to null after they are freed. This is reproducible. I'm not  
>> familiar
>> enough with the event loop yet to suggest a correction. How should we
>> proceed?
>
> I do not see the case you are talking about. In iax.c, in the block
> with the comment "Decrement remaining retries", starting at line 3357,
> the event variable is not used. The event variable is reused at line
> 3342 where it is assigned to point at newly malloc()ed memory.
> Stylistically, this reuse of event may not be awesome, but
> functionally in this particular case we have already guaranteed event
> to be null prior to reassigning it.
>
> I'm going to need more details about exactly which variables are
> employed in a sketchy manner and where it is happening.
>
> Note that I am referencing the head of iaxclient trunk. Note also that
> I have some other iaxclient and libiax2 cleanups that I will be
> committing to trunk soon (possibly today) that are unrelated to this
> issue.
>
> Thanks,
> Pete

Re: [Iaxclient-devel] crash in iax_event_free on mac

[Peter G. <jpg...@gm...>]

Hi Dennis,

On Tue, Jun 24, 2008 at 9:14 AM, Dennis Christopher
<dch...@pi...> wrote:
> Peter,
> I have set an environment variable to detect re-use of freed pointers and I
> can see a case in iax_get_event (near  " Decrement remaining retries ") that
> goes wrong because it references an event returned from iax_get_sched()
> whose event ptr is null. In the code generally this seems possible because
> freed ptrs are not
> set to null after they are freed. This is reproducible. I'm not familiar
> enough with the event loop yet to suggest a correction. How should we
> proceed?

I do not see the case you are talking about. In iax.c, in the block
with the comment "Decrement remaining retries", starting at line 3357,
the event variable is not used. The event variable is reused at line
3342 where it is assigned to point at newly malloc()ed memory.
Stylistically, this reuse of event may not be awesome, but
functionally in this particular case we have already guaranteed event
to be null prior to reassigning it.

I'm going to need more details about exactly which variables are
employed in a sketchy manner and where it is happening.

Note that I am referencing the head of iaxclient trunk. Note also that
I have some other iaxclient and libiax2 cleanups that I will be
committing to trunk soon (possibly today) that are unrelated to this
issue.

Thanks,
Pete

Re: [Iaxclient-devel] crash in iax_event_free on mac

[Dennis C. <dch...@pi...>]

Peter,

I have set an environment variable to detect re-use of freed pointers  
and I can see a case in iax_get_event (near  " Decrement remaining  
retries ") that goes wrong because it references an event returned  
from iax_get_sched() whose event ptr is null. In the code generally  
this seems possible because freed ptrs are not
set to null after they are freed. This is reproducible. I'm not  
familiar enough with the event loop yet to suggest a correction. How  
should we proceed?

Dennis Christopher
Pixion



On 10-Jun-08, at 5:23 PM, iaxclient-devel- 
re...@li... wrote:

> On Fri, May 30, 2008 at 12:45 PM, Dennis Christopher
> <dch...@pi...> wrote:
>> I have a build of 2.0.2 running on mac OS X 10.4. I'm getting a  
>> somewhat
>> reproducible
>> crash in iax_event_free, which doesnt seem associated with any  
>> particular
>> audio event. Can anyone suggest what I might look for here?
>> The offending symbol is the free call, which typically would be a
>> non-allocated ptr being freed, or one that has already been freed.
>
> A stack trace would help. How reproducible is this problem? Does the
> problem happen with 2.1beta3 or the trunk?
>
> Pete

[Iaxclient-devel] sched_priority

[Jean-Denis G. <jd....@sy...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I recently moved to latest versions (2.1beta3 and trunk), and though it
worked very well on first test system (much improved sound quality
comparing to old versions), it didn't work on another system. Both
systems are Linux, and I finally found that the problem was related to
setting the priority in unixfuncs.c: requested priority (+4) cannot be
set for a normal user (it's working for root of course).

I already reported same problem long ago, but maybe I'm the only one
affected by this...
http://sourceforge.net/mailarchive/message.php?msg_id=4366C3DF.2010308%40sysnux.pf

Patch attached.


Thanks,
- --
Jean-Denis Girard

SysNux                  Systèmes  Linux  en Polynésie française
http://www.sysnux.pf/   Tél: +689 50 10 40 / GSM: +689 79 75 27
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mandriva - http://enigmail.mozdev.org

iEYEARECAAYFAkhf9IQACgkQuu7Rv+oOo/j09gCgrY74oHHnlC6lyDrADTsRnhc+
Iu0AoKdkQNUk5s6TyZRAzOMN1q6c4/e+
=TGio
-----END PGP SIGNATURE-----

Re: [Iaxclient-devel] [iaxclient] image format

[Paulo V. <vic...@gm...>]

Hi Bill,
Some capture devices I was testing don't have support to YUV-style format:

(I was using **iaxclient 2.0.1**)
 "@device:pnp:\\?\usb#vid_0ac8&pid_303b#5&6e0df6e&0&1#{65e8773d-8f56-11d0

-a3b9-00a0c9223196}\global"

320 x 240 0xe436eb7d  - Rejecting this format.

352 x 288 0xe436eb7d  - Rejecting this format.

160 x 120 0xe436eb7d  - Rejecting this format.

176 x 144 0xe436eb7d  - Rejecting this format.

640 x 480 0xe436eb7d  - Rejecting this format.

800 x 600 0xe436eb7d  - Rejecting this format.

1024 x 768 0xe436eb7d  - Rejecting this format.

1280 x 960 0xe436eb7d  - Rejecting this format.

did not match media type

Just have RGB24…

But now,with libvidcap (iaxclient 2.1) , it is able to accept rgb24 from
capture device and to delivery in YUV-format to iaxclient ( it's too good  to
know about libvidcap internals possibilities )

Thank you

Paulo

On Fri, Jun 13, 2008 at 3:23 PM, Bill Cholewka <bc...@ya...> wrote:

> Hi Paulo,
>
> It depends on what you mean by support. If a video capture device provides
> images in this format (rgb24), iaxclient can get these images. But, they
> will have been converted to one of the three formats you mentioned.
>
> Libvidcap, which performs the capture and conversion, has conversion
> functions in its external api which convert from each of these three format
> to the remaining two. Internally, however, it has conversion functions to
> convert from internally-supported (at capture time) formats (rgb555, yvu9,
> 2vuy, rgb24) to the three formats it exposes.
>
> If you're looking to get the captured images in an rgb24 format, one of
> libvidcap's internal functions could be adapted to convert from rgb32 to
> rgb24.
>
> Does this help?
>
> Regards,
> Bill
>
> ----- Original Message ----
> From: Paulo Vicentini <vic...@gm...>
> To: Iaxclient Mailing List <iax...@li...>
> Sent: Tuesday, June 10, 2008 3:26:18 PM
> Subject: [Iaxclient-devel] [iaxclient] image format
>
>  Hi,
>
> Iaxclient 2.0.1 (with video) doesn't support MEDIASUBTYPE_RGB24 (Windows
> IA-32) color format?right?
>
>
>
> I saw support just for (sub-sampled ones) :
>
> #define IMAGE_FORMAT_I420    0x30323449
>
> #define IMAGE_FORMAT_IYUV    0x56555949
>
> #define IMAGE_FORMAT_YUY2    0x32595559
>
>
> Is this a theora's encoding requirement?
>
> Thanks
> Paulo
>

Re: [Iaxclient-devel] [iaxclient] image format

[Bill C. <bc...@ya...>]

Hi Paulo,

It depends on what you mean by support. If a video capture device provides images in this format (rgb24), iaxclient can get these images. But, they will have been converted to one of the three formats you mentioned.

Libvidcap, which performs the capture and conversion, has conversion functions in its external api which convert from each of these three format to the remaining two. Internally, however, it has conversion functions to convert from internally-supported (at capture time) formats (rgb555, yvu9, 2vuy, rgb24) to the three formats it exposes.

If you're looking to get the captured images in an rgb24 format, one of libvidcap's internal functions could be adapted to convert from rgb32 to rgb24.

Does this help?

Regards,
Bill


----- Original Message ----
From: Paulo Vicentini <vic...@gm...>
To: Iaxclient Mailing List <iax...@li...>
Sent: Tuesday, June 10, 2008 3:26:18 PM
Subject: [Iaxclient-devel] [iaxclient] image format


 Hi, 
Iaxclient 2.0.1 (with video) doesn't support MEDIASUBTYPE_RGB24 (Windows IA-32) color format?right?
 
I saw support just for (sub-sampled ones) : 
#defineIMAGE_FORMAT_I420    0x30323449
#defineIMAGE_FORMAT_IYUV    0x56555949
#defineIMAGE_FORMAT_YUY2    0x32595559
 
Is this a theora's encoding requirement?
 
Thanks 
Paulo

Re: [Iaxclient-devel] CTI application using iaxclient?

[Jean-Denis G. <jd....@sy...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

jav...@ya... a écrit :
> Hi
> 
> I'm using asterisk to receive SIP calls and have a small office with x-lite as voip softphone.
> Everything is OK, I can make/receive calls but this is going to grow (more agents from different offices) and I'm looking for a different approach.
> 
> My idea is to use a iax client (to avoid NAT problems), and I want to send additional info to the client to launch an speciffic url to attend the call. I'd like asterisk to send this url with the call, and the client to launch de url.
> I have seen iax events for text and url. Does this function as I think? Do you know if it is possible to send additional info from asterisk and receive it in iaxclient to execute some action?

<shameless plug>
Did you have a look at MozPhone (http://moziax.mozdev.org)?
It's a Firefox extension IAX softphone. It displays URL received from
Asterisk in Firefox, and also let you make call from web pages using
simple tags, like <a href="tel://123456">call me</a>.
IAX text messages are used to chat with your correspondent.
</shameless plug>

Thanks,
- --
Jean-Denis Girard

SysNux                  Systèmes  Linux  en Polynésie française
http://www.sysnux.pf/   Tél: +689 50 10 40 / GSM: +689 79 75 27
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mandriva - http://enigmail.mozdev.org

iEYEARECAAYFAkhSougACgkQuu7Rv+oOo/ivbwCfRBHPOIi5qD+yOWInF+bzKedv
I9sAnRZ1f70GlS7ipRUQqJu4sQi0l/Ft
=rK2d
-----END PGP SIGNATURE-----

Re: [Iaxclient-devel] iax2 video X Asterisk

[Paulo V. <vic...@gm...>]

Thank you for your comment and file.

Paulo

On Fri, Jun 13, 2008 at 12:11 PM, Peter Grayson <jpg...@gm...> wrote:

> On Fri, Jun 13, 2008 at 10:53 AM, Paulo Vicentini
> <vic...@gm...> wrote:
> > Hi,
> >
> > (iaxclient-2.1beta3)
> >
> >  I am able to make video+audio call with two iaxclients without using
> > asterisk server, but using asterisk I got video codec failed negotiation…
> >
> >
> >
> > I tried  CONTROL:STARTVIDEO with no success
> >
> >
> >
> > I saw posts related to Generic Media Frame Specification / Video codec
> > negotiation in IAX / etc
> >
> >
> >
> > I am not "negotiating" *video* codecs (format =  IAXC_FORMAT_THEORA) ,
> but
> >  this problem is related to audio+video (multiple medias) negotiation, is
> > that correct?
> >
> >
> >
> > What is the current status of this issue? Is it possible to make
> audio+video
> > calls thru Asterisk with IAXclient?
>
> Asterisk must be patched to include theora support if you want to use
> theora as your video codec. The attached patch should be sufficient.
> It is against asterisk-1.4.20.1.
>
> Pete
>

Re: [Iaxclient-devel] iax2 video X Asterisk

[Peter G. <jpg...@gm...>]

On Fri, Jun 13, 2008 at 10:53 AM, Paulo Vicentini
<vic...@gm...> wrote:
> Hi,
>
> (iaxclient-2.1beta3)
>
>  I am able to make video+audio call with two iaxclients without using
> asterisk server, but using asterisk I got video codec failed negotiation…
>
>
>
> I tried  CONTROL:STARTVIDEO with no success
>
>
>
> I saw posts related to Generic Media Frame Specification / Video codec
> negotiation in IAX / etc
>
>
>
> I am not "negotiating" *video* codecs (format =  IAXC_FORMAT_THEORA) , but
>  this problem is related to audio+video (multiple medias) negotiation, is
> that correct?
>
>
>
> What is the current status of this issue? Is it possible to make audio+video
> calls thru Asterisk with IAXclient?

Asterisk must be patched to include theora support if you want to use
theora as your video codec. The attached patch should be sufficient.
It is against asterisk-1.4.20.1.

Pete

Re: [Iaxclient-devel] iax2 video X Asterisk

[Paulo V. <vic...@gm...>]

Hi,

(iaxclient-2.1beta3)

 I am able to make video+audio call with two iaxclients without using
asterisk server, but using asterisk I got video codec failed negotiation…



I tried  CONTROL:STARTVIDEO with no success



I saw posts related to Generic Media Frame Specification / Video codec
negotiation in IAX / etc



I am not "negotiating" *video* codecs (format =  IAXC_FORMAT_THEORA) ,
but  this
problem is related to audio+video (multiple medias) negotiation, is that
correct?



What is the current status of this issue? Is it possible to make audio+video
calls thru Asterisk with IAXclient?

Maybe I am lacking something in iax.conf or other …


Thank you


Paulo


On Thu, Jun 12, 2008 at 4:22 PM, Paulo Vicentini <vic...@gm...>
wrote:

> Hi,
> Do you know any patch / hack (to asterisk) in order to set up video calls
> thru Asterisk (1.4.21  / 1.6 ) with IAXClient ?
>
> Thanks
>
> Paulo
>

[Iaxclient-devel] iax2 video X Asterisk

[Paulo V. <vic...@gm...>]

Hi,
Do you know any patch / hack (to asterisk) in order to set up video calls
thru Asterisk (1.4.21  / 1.6 ) with IAXClient ?

Thanks

Paulo

[Iaxclient-devel] VS 2008

[David B. <Dav...@36...>]

Tried compiling under under VS 2008 and got:

error C3163: '_vsnprintf': attributes inconsistent with previous declaration

Fixed by removing vsnprintf=_vsnprintf from "Preprocessor Definitions" in the project options.

For error about sscanf undefined added "#include <stdio.h>" to sox/resample.c.

For error about exit undefined added "#include <stdlib.h> " to sox/soxcompat.c.

Compiled OK after that.  This was with a fairly old version on iaxclient sources, but may be of help.

David

360CRM Limited, registered address, Caledonia House, 89 Seaward Street, Glasgow, G41 1HJ, Registered in Scotland, company number SC261952.
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of 360CRM Ltd.  This email does not form any part of a contract.  If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone.  Please contact the sender if you believe you have received this email in error.

[Iaxclient-devel] [iaxclient] image format

[Paulo V. <vic...@gm...>]

 Hi,

Iaxclient 2.0.1 (with video) doesn't support MEDIASUBTYPE_RGB24 (Windows
IA-32) color format?right?



I saw support just for (sub-sampled ones) :

#define IMAGE_FORMAT_I420    0x30323449

#define IMAGE_FORMAT_IYUV    0x56555949

#define IMAGE_FORMAT_YUY2    0x32595559


Is this a theora's encoding requirement?

Thanks
Paulo

Re: [Iaxclient-devel] CTI application using iaxclient?

[Peter G. <jpg...@gm...>]

On Tue, Jun 10, 2008 at 10:26 AM,  <jav...@ya...> wrote:
> Hi
>
> I'm using asterisk to receive SIP calls and have a small office with x-lite as voip softphone.
> Everything is OK, I can make/receive calls but this is going to grow (more agents from different offices) and I'm looking for a different approach.
>
> My idea is to use a iax client (to avoid NAT problems), and I want to send additional info to the client to launch an speciffic url to attend the call. I'd like asterisk to send this url with the call, and the client to launch de url.
> I have seen iax events for text and url. Does this function as I think? Do you know if it is possible to send additional info from asterisk and receive it in iaxclient to execute some action?

I don't know how you think iax events function, but I think that text
and URL messages are reasonable to use for doing what you are talking
about. The draft iax2 protocol specification has more details about
this:

  http://tools.ietf.org/html/draft-guy-iax-04

Iaxclient is just going to forward these events to the application --
iaxclient does not take any other action.

Pete