Re: [Hydrogen-devel] Feat. Req.: Cheating 5tuplets and 7tuplets Res. + 16ths Res. for Pattern Size

[Philipp M. <the...@go...>]

Hey Stefano,

On 8/16/19 12:37 AM, Stefano Carbonelli via Hydrogen-devel wrote:
> The small length differences are not so noticeable for me... I would
> use this subdivision even if not exact.
> Quarter and 8th 5-tuplet resolution are not really needed as one can
> use 16th 5tuplet res. skipping some ticks... but they could be
> implemented according to the previous positions.
> [...]
> Would it be easy for you to implement this?

I personally dislike the idea of introducing this imprecision in order
to approximate the tuplet behavior. You might not notice it at higher
speeds but it could be quite obvious for very slow patterns. It's
probably best to have a look at the current implementation and to come
up with a clever way to patterns at a different granularity.

Unfortunately, this is not that simple because it requires you to
understand how the core of Hydrogen does process audio. I prepared some
documentation in https://github.com/hydrogen-music/hydrogen/pull/737,
which might help getting you started. But it's still quite some work.

> Would you add this option (maybe on/off button that enables *16th-note
> resolution for pattern size*...)?

Currently there are not that much people involved in developing new
features or fixing bugs in Hydrogen. In addition, we already do have
very long todo list with issues that pilled up as well as not that much
time to dedicate to the project. So, the fastest way to get a new
feature is to implement it yourself.

You already did a good job in figuring out the right files to change in
your pull request. Why not going further? :) I'll do my best to support
you in your efforts.

Cheers,

Phil