Re: [Hydrogen-devel] 1.0.0 Roadmap

[<ma...@sm...>]

Hi Jérémy! (and everyone else..),

while debugging something completely different, i found out that 
Hydrogen currently uses absolute path names for all samples (documented 
in https://github.com/hydrogen-music/hydrogen/issues/645). This could be 
one source of the current problems, it might be caused by a fragile and 
stupid algorithm from my side in combination with your recent clean up 
work.

During debugging i found out that Filesystem::file_is_partof_drumkit 
(https://github.com/hydrogen-music/hydrogen/blob/fbe7a78fd829d6e4e0b3d30b03037224ac2e680a/src/core/src/helpers/filesystem.cpp#L532) produces wrong results because it calls drumkit_exists with a drumkit string which is exactly one character to short, for example "mKit" iso. "GmKit". It might be the case that this was caused by adding a "/" to the default path names, but thats just a speculation at the moment.

On the other hand, it seems that this specific problem does not occur 
with Hydrogen 1.0-beta1, so it seems to be unlikely that this is the 
only source of the current problems (since the other reported issues are 
dating back to 1.0beta1 and even 0.9.7. But it seems that having tests 
for the sanity of generated files could be a good idea :)

Best regards,
Sebastian


Am 14.08.2018 07:10, schrieb Jérémy Zurcher:
> Hello,
> 
> good job Mauser !
> 
> As I've been lately working on cleaning the xml data,
> I've assigned the above import/export tickets to myself.
> And will give them a good go !!
>