|
From: Jérémy Z. <je...@as...> - 2018-04-10 22:49:50
|
Hi H2 devs, just to draw your attention on this, with the hope that one day hydrogen GUI code will be much cleaner. I just fixed https://github.com/hydrogen-music/hydrogen/issues/576 with https://github.com/hydrogen-music/hydrogen/commit/125e2968759d8d1daef25d3a81ed1fb229b46a4b in the button callback, GUI code, check if it is possible to unmute the playback track ... 40 minutes later, I thought, that's stupid, the lower API should answer the GUI telling in which state it is after completing the call ... then : https://github.com/hydrogen-music/hydrogen/commit/35f8d1cea773e951dc931363c72d5e5864c9f410 Song::set_playback_track_enabled is safe to call from anywhere Hydrogen::setPlaybackTrackState is safe to call from anywhere SongEditorPanel::mutePlaybackTrackBtnPressed is so simple happy coding ;) Jeremy |