Re: [Hydrogen-devel] [PATCH] MIDI-out stubs for CoreMidi / PortMidi(Re: [PATCH] MIDI-out feature)

[<jl...@im...>]

Hi there

MIDI out is an absolutely nice idea, keep it up :-)

> 	I poked around for a few minutes and see more or less what needs to be
> done to handle the note length. Unfortunately it's not a five minute fix
> since from what I can tell notes are only queued up if they haven't
> reached the end of their sample (which makes perfect sense).

If I understand correctly, the sending of a note on event in your code
starts in note_on() in sampler.cpp with the line that says
  Hydrogen::get_instance()->getMidiOutput()->handleQueueNote(note);

In the process() function in that file, the notes are taken out of the
queue around line 121 (if there are too many notes) and 135 (notes that
have played for as long as they should). You could send the note off's
from there I suppose?



>
> 	I'm thinking I need to maintain another queue of note off events, and
> checking for those to trigger in hydrogen.cpp
> audioEngine_process_playNotes(), or perhaps somewhere in
> audioEngine_updateNoteQueue() and audioEngine_process(). I just need to
> find the time to explore a little more.

Those two functions (and with them, others) in hydrogen.cpp are a bit of a
mess. I am working on an "evil scheme" here to reimplement most of the
sequencing code in that file (in fact, last week I looked at the code for
the first time in about a half year, and I'm going to code on it next week
I hope).
What I'm trying to say is that if you hack on that part of hydrogen.cpp
it'll probably have to be worked over again if I get that thing to work
that I'm working on.

 - Jakob Lund.

>
> 	As for setting up a branch, how do I go about it? I'm guessing there's
> a repository admin I need to get in touch with?
>
>
> On Sun, 2009-01-18 at 20:18 +0100, m.w...@gm... wrote:
>> hey,
>> take a look in note.h. and in DrumPatternEditor.cpp line 140 and 292.
>> sampler.cpp at int Sampler::__render_note_no_resample and int
>> Sampler::__render_note_resample will check notelenght for the note
>> sample process.
>>
>> hope this will help you.
>>
>> in note.h you see also one for the moment more or less unused feature of
>> hydrogen. the class NoteKey.
>> this is a great feature i have used in my fx_and_sample_fun_branch.
>> default current h2 set notekey to C.
>> but sampler.cpp is ready to resample the sample with oter notekeys. i
>> don't know if this features will used in 0.9.5 i hope that we implement
>> my
>> note_key notepropertiesruler from my branch which use the NoteKey class.
>> but if we implement this notekey feature the midi note message change
>> for each netekey.
>> in my branch i have solve this problem by changing the keyboard layout.
>> * classic layout plays the whole drumset and each key is an other
>> instrument.
>> * instrument layout plays only one instrument with other note_keys c d e
>> f and so on.
>>
>> as gabriel i also think we create an extra branch for it, and you get
>> write access to svn.
>>
>> greetings wolk
>>
>> > 	As for the note off messages, I wasn't aware of the note length
>> feature
>> > in Hydrogen. Do you know offhand where might be an appropriate place
>> to
>> > handle sending a note off when the note length reaches its end? I can
>> go
>> > hunting for a spot later, but a pointer would be helpful :).
>>
>> greetings wolke
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by:
>> SourcForge Community
>> SourceForge wants to tell your story.
>> http://p.sf.net/sfu/sf-spreadtheword
>> _______________________________________________
>> Hydrogen-devel mailing list
>> Hyd...@li...
>> https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by:
> SourcForge Community
> SourceForge wants to tell your story.
> http://p.sf.net/sfu/sf-spreadtheword
> _______________________________________________
> Hydrogen-devel mailing list
> Hyd...@li...
> https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
>