Hello José,
done with commit r2915 with little modification, please check.
Tested with HGT sample, other samples and my app CLLOG.
Added also some documentation items i found during the
developing work.
With regards,
MNI TNX, 73 es 55 de
DF7BE, Wilfried
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hello,
committed your corrections with r2916. Tested again. Please check.
Please exchange your local copy of include/windows.ch with file from repository,
so that my little modifications (merged with WinMerge) are preserved.
With regards,
MNI TNX, 73 es 55 de
DF7BE, Wilfried
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
New version.
Changed to hbmk default variable HBMK_HAS_GTWVG.
HBMK2 defines variable when use gtwvg.hbc on project.
Once it is official, better to use it.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
What do you think about to move HDM_GETITEMCOUNT to windows.ch?
There are another variables on another source-code, including variables existing on hbwin.ch
I will review each one.
Last edit: José M. C. Quintas 2020-12-15
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hello José,
committed your corrections with r2917. Tested again. Please check.
Please exchange your local copy of all committed files with files from repository.
===================================================================
What do you think about to move HDM_GETITEMCOUNT to windows.ch?
There are another variables on another source-code,
including variables existing on hbwin.ch
I will review each one.
===================================================================
Also done, look at EOF of windows.ch.
Found all files with #define HDM_GETITEMCOUNT, commented out
with info for moving to windows.ch.
Many success for programming your HWGUI application.
With regards,
MNI TNX, 73 es 55 de
DF7BE, Wilfried
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hello José
your last modification committed with r2924.
If you will post more mods in the future, i think
this ticket should be left open, until you give the
message, that you have finished. TNX.
Please exchange your local copy of windows.ch with the
committed version. I have made some little modifications
(checked with WinMerge):
define DMPAPER_A3 8 / DIN A3 297 x 420 mm /
define DMPAPER_A4 9 / DIN A4 210 x 297 mm /
define DMPAPER_A5 11 / DIN A5 148 x 210 mm /
define DMPAPER_A6 70 / DIN A6 105 x 148 mm /
ifndef WVTWINLG_CH
##define HDM_GETITEMCOUNT 4608
endif
/ ======================= EOF of windows.ch ======================= /
With regards,
MNI TNX, 73 es 55 de
DF7BE, Wilfried
Last edit: Wilfried Brunken 2021-01-04
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Situation 1: you compile using -lgtwvg, this only adds the library,
Situation 2: you compile using gtwvg.hbc, this add extra ch files to all sources that conflicts with hwgui
hbmk2 has the exported HBMK_HAS_GTWVG when found "gtwvg.hbc" on list compilation.
On previous changes I use a new variable, but after this I change to use only HBMK_HAS_GTWVG.
On user side:
No extra changes: or user adds on compilation -lgtwvg, or user adds gtwvg.hbc or users do not add nothing
Changes will take effect only if use gtwvg.hbc, and this is ok, because only gtwvg.hbc add extras ch files.
Note: you can confirm this looking at gtwvg.hbc, this line
"headers=hbgtwvg.ch wvgparts.ch wvtwin.ch"
this lines add CH to all PRGs. and this causes the conflict, but this lines are on official Harbour gtwvg
Note2: when I send changes at first time, I do not know about already exists HBMK_HAS_GTWVG on HBMK2, then later change to use it.
Ok, i suggest you to create a separate file (e.g. - hwggtwvg.ch), move all headers, defines from windows.ch to hwggtwvg.ch, and then use HBMK_HAS_GTWVG in build script if you want to include support gtwvg to hwgui.
And always check a correct build by hbmk2 hwgui.hbp, because it's a first step to install hwgui from source.
And look at windows.ch, it was a simple reading file and became a ... don't know, sorry.
And what a GOAL of GTWVG and HWGUI, i don't understand now, can you explain your vision of using of it and how, thanks.
Regards.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
You do not understand, changes are not do add #defines, but to remove #defines.
For me, goal is all using same files to compile, not each one with her own source code.
We need to work together, not divide on small groups.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Please, check the best way to update, because there are several files, and will have more files.
start point is hwgui of yesterday https://github.com/JoseQuintas/hwgui/commits/main
and there are more changes to do, until compiles using -w3 -es2.
The best would be to remains only hbp/hbc/hbm files.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
On my machine format is windows cr/lf ansi ptbr
on github format is linux, utf-8
there are several files on different folders, may be a zip with them
but there are deleted files too.
I am checking all hbp, compilation -w3 -es2.
but on each hwgui update, I need rewrite github history, and this is not an easy work, until updates are on hwgui source-forge.
An important thing is that is needed to test on Linux too, but I do not have Linux here, except Windows 10 subsystem without graphic execution (seems this will be possible later).
Last edit: José M. C. Quintas 2021-01-05
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hello José,
done with commit r2915 with little modification, please check.
Tested with HGT sample, other samples and my app CLLOG.
Added also some documentation items i found during the
developing work.
With regards,
MNI TNX, 73 es 55 de
DF7BE, Wilfried
Hi!
Got error:
some corrections
There are some #defines on source code that already exists on wvtwinlg.ch or hbwin.ch
At same time, all windows API defines are on hbwin.ch but with prefix WIN_ as example:
WIN_WM_CREATE, WIN_WM_DESTROY, and to use on C and PRG.
No problem to hwgui, but not sure if could be used the same on hwgui.
take a look on links:
https://github.com/vszakats/hb/blob/master/contrib/gtwvg/wvtwinlg.ch
https://github.com/vszakats/hb/blob/master/contrib/hbwin/hbwin.ch
Hello,
committed your corrections with r2916. Tested again. Please check.
Please exchange your local copy of include/windows.ch with file from repository,
so that my little modifications (merged with WinMerge) are preserved.
With regards,
MNI TNX, 73 es 55 de
DF7BE, Wilfried
Now ok, thanks.
New version.
Changed to hbmk default variable HBMK_HAS_GTWVG.
HBMK2 defines variable when use gtwvg.hbc on project.
Once it is official, better to use it.
forgot to remove annotation about old variable, now ok.
hwgui/source/winapi/hbrowse.prg
Note: I do not know how to desactivate auto format from this text, then use quotes on each line of the code.
"ifndef HBMK_HAS_GTWVG
" #define HDM_GETITEMCOUNT 4608
''#endif
What do you think about to move HDM_GETITEMCOUNT to windows.ch?
There are another variables on another source-code, including variables existing on hbwin.ch
I will review each one.
Last edit: José M. C. Quintas 2020-12-15
hwgui/source/winapi/hdatepic.prg
"#ifndef HBMK_HAS_GTWVG
" #define NM_KILLFOCUS -8
" #define NM_SETFOCUS -7
"#endif
Hello José,
committed your corrections with r2917. Tested again. Please check.
Please exchange your local copy of all committed files with files from repository.
===================================================================
What do you think about to move HDM_GETITEMCOUNT to windows.ch?
There are another variables on another source-code,
including variables existing on hbwin.ch
I will review each one.
===================================================================
Also done, look at EOF of windows.ch.
Found all files with #define HDM_GETITEMCOUNT, commented out
with info for moving to windows.ch.
Many success for programming your HWGUI application.
With regards,
MNI TNX, 73 es 55 de
DF7BE, Wilfried
Hello José,
Is all OK, so that this ticket could be closed ?
A happy new year,
with regards,
MNI TNX, 73 es 55 de
DF7BE, Wilfried
I will send more changes later, but you can close it.
Hello José
your last modification committed with r2924.
If you will post more mods in the future, i think
this ticket should be left open, until you give the
message, that you have finished. TNX.
Please exchange your local copy of windows.ch with the
committed version. I have made some little modifications
(checked with WinMerge):
define DMPAPER_A3 8 / DIN A3 297 x 420 mm /
define DMPAPER_A4 9 / DIN A4 210 x 297 mm /
define DMPAPER_A5 11 / DIN A5 148 x 210 mm /
define DMPAPER_A6 70 / DIN A6 105 x 148 mm /
ifndef WVTWINLG_CH
##define HDM_GETITEMCOUNT 4608
endif
/ ======================= EOF of windows.ch ======================= /
With regards,
MNI TNX, 73 es 55 de
DF7BE, Wilfried
Last edit: Wilfried Brunken 2021-01-04
Hi!
Again:
Situation 1: you compile using -lgtwvg, this only adds the library,
Situation 2: you compile using gtwvg.hbc, this add extra ch files to all sources that conflicts with hwgui
hbmk2 has the exported HBMK_HAS_GTWVG when found "gtwvg.hbc" on list compilation.
On previous changes I use a new variable, but after this I change to use only HBMK_HAS_GTWVG.
On user side:
No extra changes: or user adds on compilation -lgtwvg, or user adds gtwvg.hbc or users do not add nothing
Changes will take effect only if use gtwvg.hbc, and this is ok, because only gtwvg.hbc add extras ch files.
Note: you can confirm this looking at gtwvg.hbc, this line
"headers=hbgtwvg.ch wvgparts.ch wvtwin.ch"
this lines add CH to all PRGs. and this causes the conflict, but this lines are on official Harbour gtwvg
Note2: when I send changes at first time, I do not know about already exists HBMK_HAS_GTWVG on HBMK2, then later change to use it.
Last edit: José M. C. Quintas 2021-01-05
Hi!
Situation 1, situation 2, ..., situation X, nooooo.
I'm build hwgui using the standard command
it's descibed in install.txt, that's all what i do to check a correct build HWGUI after refresh code from repository.
Regards.
ok. I will check about existing anything creating the #define on files, because may be it was created for tests purpose.
Problem was on windows.ch,
/
Check button
/
$ifdef HBWINCH
Correct is ifndef
The only thing to do is to replace windows.ch with the attached on previous message.
Ok, i suggest you to create a separate file (e.g. - hwggtwvg.ch), move all headers, defines from windows.ch to hwggtwvg.ch, and then use HBMK_HAS_GTWVG in build script if you want to include support gtwvg to hwgui.
And always check a correct build by hbmk2 hwgui.hbp, because it's a first step to install hwgui from source.
And look at windows.ch, it was a simple reading file and became a ... don't know, sorry.
And what a GOAL of GTWVG and HWGUI, i don't understand now, can you explain your vision of using of it and how, thanks.
Regards.
You do not understand, changes are not do add #defines, but to remove #defines.
For me, goal is all using same files to compile, not each one with her own source code.
We need to work together, not divide on small groups.
Please, check the best way to update, because there are several files, and will have more files.
start point is hwgui of yesterday
https://github.com/JoseQuintas/hwgui/commits/main
and there are more changes to do, until compiles using -w3 -es2.
The best would be to remains only hbp/hbc/hbm files.
What do you mean
On my machine format is windows cr/lf ansi ptbr
on github format is linux, utf-8
there are several files on different folders, may be a zip with them
but there are deleted files too.
I am checking all hbp, compilation -w3 -es2.
but on each hwgui update, I need rewrite github history, and this is not an easy work, until updates are on hwgui source-forge.
An important thing is that is needed to test on Linux too, but I do not have Linux here, except Windows 10 subsystem without graphic execution (seems this will be possible later).
Last edit: José M. C. Quintas 2021-01-05
So, you get copy of code from sf, then put it to github, make changes, test it, take a some file from github and return it to sf, yes?
But what is the goal or idea a combination GTWVG and HWGUI? How it should works?
Regards.