From: Roland S. <rol...@ch...> - 2010-11-25 08:28:11
|
Hi, as I am looking at the 'Hyphen 2.6' library (great library, btw!), I am wondering about a particular line in the code within the hnj_hyphen_rhmin() function: if (!utf8 || (word[j] & 0xc0) != 0xc0) i++; This increments i in all cases, except if the current character is a UTF-8 multi-byte sequence starting character. Shouldn't this rather be if (!utf8 || (word[j] & 0xc0) != 0xc80) i++; i.e., rather "skipping" multi-byte follow-up characters in the counting. This would also mirror the corresponding line in hnj_hyphen_lhmin(). Or am I misunderstanding the intent here? Cheers, - Roland |
From: Németh L. <ne...@op...> - 2010-12-03 08:13:01
|
Hi Roland, This line is a little bit tricky, see also the cycle variables. But I have added a new rhmin test to the last release, too. Thanks for your report and kind words, Best regards, László 2010/11/25 Roland Steiner <rol...@ch...>: > Hi, > as I am looking at the 'Hyphen 2.6' library (great library, btw!), I am > wondering about a particular line in the code within the hnj_hyphen_rhmin() > function: > > if (!utf8 || (word[j] & 0xc0) != 0xc0) i++; > > This increments i in all cases, except if the current character is a UTF-8 > multi-byte sequence starting character. Shouldn't this rather be > > if (!utf8 || (word[j] & 0xc0) != 0xc80) i++; > > i.e., rather "skipping" multi-byte follow-up characters in the counting. > This would also mirror the corresponding line in hnj_hyphen_lhmin(). > Or am I misunderstanding the intent here? > > Cheers, > - Roland > > ------------------------------------------------------------------------------ > Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! > Tap into the largest installed PC base & get more eyes on your game by > optimizing for Intel(R) Graphics Technology. Get started today with the > Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. > http://p.sf.net/sfu/intelisp-dev2dev > _______________________________________________ > Hunspell-devel mailing list > Hun...@li... > https://lists.sourceforge.net/lists/listinfo/hunspell-devel > > |