[Httpunit-develop] (no subject)

[<rus...@ac...>]

Ken Hygh wrote:

> I like the tool, it's a great addition to my repertoire.

Thanks :)

> I have a page that caused HttpUnit some problems, that has a form that
> contained a hidden input as well as a table that contained other input
> elements, and the latter didn't have a TYPE attribute. HttpUnit successfully
> saw the hidden element, but didn't retrieve the other parameter values.  I
> changed WebForm.getParameterDefaults() to handle this:

> old:
>     if (type == null) type = "TEXT";
>
>     if (type.equals( "TEXT" ) | type.equals( "HIDDEN" ) | type.equals(
  "PASSWORD" )) {


> new:
>     if (type == null || "".equals(type)) type = "TEXT";
>
>     if (type.equals( "TEXT" ) || type.equals( "HIDDEN" ) || type.equals(
  "PASSWORD" )) {

> The second change just short-circuits the other checks if type=TEXT, 
> instead of evaluating them all every time.

Good catches both. Thank you. I will add this to the codebase.

> Sorry I'm clueless about how to use CVS to get this to you in a better way.

No problem. For a change this size, direct posting is fine. You can learn more 
about cvs at <http://www.red-bean.com/cvsbook/>