Menu ▾ ▴

#187 DOM parser should be customizable

pending
Wolfgang Fahl
None
5
2014-08-18
2010-01-14
Kohsuke Kawaguchi
No

HttpUnit currently uses a static method HttpUnitUtils.newParser() to obtain a parser to parse a document into DOM, but this design prevents the calling code from customizing the parse behavior (such as tweaking DTD handling, supplying a custom EntityResolver, etc.)

A better design is for WebConversation to own a DocumentBuilderFactory instance, and define a setter so that the calling code can pass in a properly configured parser factory.

Discussion

  • Wolfgang Fahl

    Wolfgang Fahl - 2012-09-12
    • assigned_to: nobody --> wolfgang_fahl
    • status: open --> pending
     

  • Wolfgang Fahl

    Wolfgang Fahl - 2012-09-12

    I've move the request to a feature request. Please supply a test case if you consider this a bug.

     

  • Wolfgang Fahl

    Wolfgang Fahl - 2012-09-12

    Dear httpunit user!

    Thank you for your bug report. We appreciate the time and effort you are putting into this.

    Please supply a testcase with the expected result for the bug report that you are asking a solution for and we'll look into implementing it. For a start you might want to get the trunk version from the subversion repository (see https://sourceforge.net/svn/?group_id=6550\)
    and have a look at the source code of some of the more than 700 JUnit based testcase in there.

    If you do not use or have subversion tool you can still directly browse our test cases via:
    http://httpunit.svn.sourceforge.net/viewvc/httpunit/trunk/httpunit/test/com/meterware/httpunit/
    Looking into one or more of the Junit Java source files
    should give you a clue on what a proper testcase for httpunit looks like, often you will probably only have to "clone" an existing testcase and modify it slightly to your needs.

    When you are ready you might want to attach the testcase (and if you already have started implementing a solution for it it also the actual code) to the patch section of the sourceforge.net tracker for patches of the httpunit project at
    https://sourceforge.net/tracker/?atid=306550&group_id=6550&func=browse.

    The main communication about further details of the development is via the httpunit developer mailinglist. You are most welcome to sign up via
    https://lists.sourceforge.net/lists/listinfo/httpunit-develop

    Yours
    The httpunit developer team

    (Russell, Wolfgang, Mark, Patrick and Tim as of 2008-04)

     

Log in to post a comment.