[Httpbl-beta] diff for apr_socket_create

[James B. <jmb...@ha...>]

After Jasper reported his compile/run problem, I had another look at the
apr_socket_create business.  The patch applied to the cvs master for my
earlier fix seems to be broken.

1) APR_MAJOR_VERSION is only available after including apr_version.h,
   which isn't in the current code - this means that despite the #if,
   all platforms try to compile the 1.9 version with apr_socket_create_ex

2) The APR >= 1 side of the #if passes four parameters where it should
   use 5 so wouldn't work anyway.

Diff/patch attached, tested on APR 1.2.

Also, with this fixed, I now get my /httpbl_diagnostics/ page. Huzzah!

There *is* a compile warning produced in complaint, but it's lost among
the many others. It's probably worth having a blitz on cleaning up the
warnings.

-jmb
-- 
James Beckett <jm...@ha...> <http://www.hackery.net/jmb/>
F601 C085 1482 B92A C812  556C A985 1497 209B 4E65