[Http-webtest-general] Re: Patch to get HarnessReport to report failures to Harness itself

[Ilya M. <il...@ma...>]

>>>>> On Mon, 08 Apr 2002 18:12:07 +1200, Martin Langhoff <ma...@cw...> said:

ML> The harness plugin in version 1-99_04 is not reporting failures
ML> correctly to Harness.

ML> This little patch solves the problem.

ML> [..skip..]

Thanx for bug report and patch. I've redone it in slighly more correct
way :)

It will be incorporated in next release of HTTP-WebTest. Right now you
may wish to use this patch instead of yours:

Index: lib/HTTP/WebTest/Plugin/HarnessReport.pm
===================================================================
RCS file: /cvsroot/http-webtest/HTTP-WebTest/lib/HTTP/WebTest/Plugin/HarnessReport.pm,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- lib/HTTP/WebTest/Plugin/HarnessReport.pm	15 Feb 2002 13:12:55 -0000	1.3
+++ lib/HTTP/WebTest/Plugin/HarnessReport.pm	8 Apr 2002 06:50:26 -0000	1.4
@@ -78,7 +78,7 @@
 	for my $subresult (@$result[1 .. @$result - 1]) {
 	    my $comment = $subresult->comment;
 	    my $ok      = $subresult->ok ? 'SUCCEED' : 'FAIL';
-	    $all_ok   &&= $ok;
+	    $all_ok   &&= $subresult->ok;
 
 	    $self->print("#   $comment: $ok\n");
 	}



ML> (Ilya, apologies for copying you against whatthe documentations
ML> recommends. The mailing list doesn't seem terribly active, and I
ML> thought you might find the patch useful.)

Well, I'm subscribed to this maillist so there are zero chances of
losing patches sent only to maillist. Anyway thank you again for
sending it me.

-- 
o    Ilya Martynov => http://martynov.org/    o
o    TIV.net       => http://tiv.net/         o