Re: [htoolkit-users] time zone bug

[Frederik E. <fre...@a5...>]

I'm attaching a patch which I've tested.

I'm also attaching a Makefile derived from Bulat's IIRC, it might be
good to include it in those directories which contain a .cabal file.

Thanks,

Frederik

On Thu, Aug 17, 2006 at 01:17:11AM +0100, Frederik Eaton wrote:
> Hi, in
>=20
> HSQL/Database/HSQL.hsc
>=20
> instance SqlBind ClockTime where
> ...
>=20
> all of the 'fromSqlValue' functions convert with respect to the local
> timezone, while 'toSqlValue' converts with respect to UTC. Thus the
> values being written are not the same, it would seem, as those being
> read. Certainly that is the case for me.
>=20
> If the three appearances of currTZ within the body of that instance
> (and not elsewhere) are changed to 0, it should fix the problem (but I
> haven't tested).
>=20
> Also, I don't understand why a custom function 'mkClockTime' has been
> written in that module (it calls 'mktime' via FFI), rather than
> calling the standard library function toClockTime which seems to do
> the same thing.
>=20
> Frederik
>=20
> On Thu, Aug 10, 2006 at 04:19:36PM +0100, Frederik Eaton wrote:
> > In HSQL, why are 'datetime' columns interpreted as being in the local
> > timezone?
> >=20
> > I would think that UTC would be more useful. If the local timezone is
> > used, then it makes it more difficult to move a server between
> > timezones, or to have multiple servers in multiple timezones.
> >=20
> > Frederik
> >=20
> > On Sat, Aug 05, 2006 at 06:59:21PM +0100, Frederik Eaton wrote:
> > > Thanks!
> > >=20
> > > On Sat, Aug 05, 2006 at 05:27:04PM +0200, Bjorn Bringert wrote:
> > > > On Aug 5, 2006, at 3:34 PM, Frederik Eaton wrote:
> > > >=20
> > > > >On Sat, Aug 05, 2006 at 11:15:19AM +0200, Bjorn Bringert wrote:
> > > > >>On Jul 31, 2006, at 12:55 PM, Frederik Eaton wrote:
> > > > >>
> > > > >>>Hi,
> > > > >>>
> > > > >>>I'm attaching another HSQL patch.
> > > > >>>
> > > > >>>It allows users to specify a port number with the server name =
in the
> > > > >>>MySQL client.
> > > > >>>
> > > > >>>Frederik
> > > > >>
> > > > >>Hi Frederik,
> > > > >>
> > > > >>the patch doesn't apply cleanly against the current CVS version=
. Is
> > > > >>there any chance you could make a patch against the CVS version
> > > > >>instead?
> > > > >
> > > > >It's a very simple modification, can't you just copy and paste f=
rom
> > > > >the patch?
> > > >=20
> > > > It appears to have been a simple whitespace mismatch problem (tab=
s in the original HSQL source). I=20
> > > > have committed your patch to CVS.
> > > >=20
> > > > Thanks!
> > > >=20
> > > > /Bj=F6rn

--=20
http://ofb.net/~frederik/