Menu
▾
▴
[HtmlUnit] [ htmlunit-Patches-1954183 ] Patch for feature request #1943761
|
From: SourceForge.net <no...@so...> - 2008-04-29 15:35:29
|
Patches item #1954183, was opened at 2008-04-29 15:22 Message generated for change (Comment added) made by mguillem You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=448268&aid=1954183&group_id=47038 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Knut Johannes Dahle (knutjda) Assigned to: Nobody/Anonymous (nobody) Summary: Patch for feature request #1943761 Initial Comment: HtmlUnit feature request 1943761: Get width, height, file size and created date for images. Given a HtmlImage it downloads the image given in src and returns info about width, height, file size,and created date. (Not the width / height HTML attributes, but the actual dimensions of the image.) You will find the source code in feature_request_1943761.patch. In the attached zip file (feature_request_1943761.zip) you will find two images used in the JUnit-tests. "mvn checkstyle:checkstyle" runs successfully and all new functionality is tested with JUnit. No existing tests breaks because of the new functionality. ---------------------------------------------------------------------- >Comment By: Marc Guillemot (mguillem) Date: 2008-04-29 17:35 Message: Logged In: YES user_id=402164 Originator: NO ups, sorry. In this case the image is ok. Concerning your patch: - can you improve the javadoc for isAccessible(). I don't really understand the need for it ;-( - can you use org.apache.commons.httpclient.util.DateUtil ather than new DateUtils - does it make sense to have saveImage()? XPage don't have any savePage() - doesn't it make more sense to get the size from the downloaded content rather that from the header? - why can getFileSize(), getCreatedDate(), and getImageWebResponse() throw UnsupportedContentTypeException? ---------------------------------------------------------------------- Comment By: Knut Johannes Dahle (knutjda) Date: 2008-04-29 16:21 Message: Logged In: YES user_id=2068578 Originator: YES I copied the image from HtmlUnit\src\test\resources\curvyCorners\1.2.9-beta\back_test.jpg. If you want I can add a new patch with another image and rewritten tests? ---------------------------------------------------------------------- Comment By: Marc Guillemot (mguillem) Date: 2008-04-29 16:03 Message: Logged In: YES user_id=402164 Originator: NO It seems to me that the provided images are (c) OPHRYS PHOTOGRAPHY and therefore I don't really want to add them to HtmlUnit's sources without authorization. Do you think that you could use other images that would not have any copyright problems or should I ask by Ophrys if we can included these images in HtmlUnit's resources? ---------------------------------------------------------------------- Comment By: Knut Johannes Dahle (knutjda) Date: 2008-04-29 15:30 Message: Logged In: YES user_id=2068578 Originator: YES File Added: feature_request_1943761.zip ---------------------------------------------------------------------- Comment By: Knut Johannes Dahle (knutjda) Date: 2008-04-29 15:25 Message: Logged In: YES user_id=2068578 Originator: YES File Added: feature_request_1943761.zip ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=448268&aid=1954183&group_id=47038 |