#1849 SgmlPage.getElementsByTagName("*") does not return all DomElement descendants

[Mark Fulton]

SgmlPage.getElementsByTagName("*") should return the same logic collection as SgmlPage.getDomElementDescendants() but it returns an empty collection instead.

[Ahmed Ashour]

Well, doing this fails DomNodeListTest.getElementsByTagName(), HtmlForm2Test.base(), HtmlElementTest.getElementsByTagName2() and HtmlPageTest.getElementsByTagName().

Please provide a test case that shows the current logic is incorrect.

[Mark Fulton]

Here is a test case for DomNodeLIstTest:

    /**

     * @throws Exception if the test fails
     */
    @Test
    public void getAllElementsBySpecialTagNameValue() throws Exception {
        final String firstContent
            = "<html><head><title>First</title></head>\n"
            + "<body>\n"
            + "<form><input type='button' name='button1' value='pushme'></form>\n"
            + "<div>a</div> <div>b</div> <div>c</div>\n"
            + "</body></html>";

        final HtmlPage page = loadPage(firstContent);

        final DomNodeList<DomElement> elements = page.getElementsByTagName("*");

        assertEquals(9, elements.getLength());
        validateDomNodeList(elements);

        final HtmlDivision newDiv = new HtmlDivision(HtmlDivision.TAG_NAME, page, null);
        page.getBody().appendChild(newDiv);
        assertEquals(10, elements.getLength());
        validateDomNodeList(elements);
    }

And here is what I inserted at the beginning of SgmlPage.getElementsByTagName(String) to get the test to pass:

        if ("*".equals(tagName)) {
            return new AbstractDomNodeList<DomElement>(this) {
                @Override
                protected List<DomElement> provideElements() {
                    final List<DomElement> res = new LinkedList<>();
                    for (final DomElement elem : getDomElementDescendants()) {
                        res.add(elem);
                    }
                    return res;
                }
            };
        }

[Ahmed Ashour]

Thanks for reporting and the test case. Now I understand the '*'.

Fixed in SVN.

[Mark Fulton]

Oh, I just realized that the same should be applied to getElementsByTagNameNS...

[Ahmed Ashour]

Also Element.getElementsByTagNameNS needs to be modified.

[Ahmed Ashour]

Thanks for the feedback, fixed in SVN.