Re: [htdig] PATCH: htdig/Retriever.cc bad_querystr

[Gilles D. <gr...@sc...>]

According to Jamie Anstice:
> Here's a patch for a bug pointed out a month or so on htdig-dev,
> and independently discovered by me a few days ago.  It fixes a 
> problem with the empty exclude_urls: and bad_query_str: attributes 
> matching everything, not nothing, on 3.2b4ish
> 
> Is htdig-general the best place for these patches, or is htdig-dev 
> preferred?

Either list will do.  Even the beta releases are commonly used enough
now that patches for them can go on the htdig-general list, as long as
the version for which the patch is intended is indicated.

However, your patch doesn't quite get to the root of the problem we
discussed on August 23-24.  The problem (other than using url instead
of ext for the bad_querystr handling) is that HtRegexList::match() isn't
properly reporting the case of a null pattern, as it should.  Geoff and
I had discussed the correct solution, but unfortunately we both dropped
the ball so it never got committed.  I'll try to do this today.

-- 
Gilles R. Detillieux              E-mail: <gr...@sc...>
Spinal Cord Research Centre       WWW:    http://www.scrc.umanitoba.ca/~grdetil
Dept. Physiology, U. of Manitoba  Phone:  (204)789-3766
Winnipeg, MB  R3E 3J7  (Canada)   Fax:    (204)789-3930