Menu

#84 If-Modified-Since not in GMT

resolved
closed-fixed
htdig (103)
5
2001-11-21
2001-11-14
Anonymous
No

I'm using htdig-3.2.0b3 with wwwoffle on a redhat-7.2
distribution. I noticed that htdig generates
If-Modified-Since headers in my locale timezone
format (CET) instead of the expected GMT date
format (rfc1123).

This patch fixed the problem, but I'm not sure this
is the correct way to handle this. Am I supposed
to use the 'locale' configuration keyword instead ?

--- htdig-3.2.0b3/htnet/HtHTTP.cc.bak Wed Nov 14 10:27:08 2001
+++ htdig-3.2.0b3/htnet/HtHTTP.cc Wed Nov 14 10:26:49 2001
@@ -582,6 +582,7 @@
// the one we already own.

if(_modification_time)
+
_modification_time->ToGMTime();
cmd << "If-Modified-Since: " <<
_modification_time->GetRFC1123() << "\r\n";

// Let's close the command

Discussion

  • Gilles Detillieux

    Logged In: YES
    user_id=149687

    Your fix will work as long as _modification_time
    isn't null, but will blow up otherwise. This bug
    is fixed correctly in the latest 3.2.0b4 snapshot.

     
  • Gilles Detillieux

    • labels: --> htdig
    • milestone: --> resolved
    • assigned_to: nobody --> grdetil
    • status: open --> closed-fixed
     

Log in to post a comment.