Menu

#1597 Sensitive information may be leaked in write of org.hsqldb.result.Result from org.hsqldb.ParserDDL

version 2.5.x
closed-rejected
None
5
2021-03-07
2020-10-30
Xiaoqin Fu
No

In org.hsqldb.ParserDDL,
private StatementSchema compileRoleGrantOrRevoke(boolean grant) {
......
while (true) {
checkIsSimpleName();
roleList.add(token.tokenString);
read();

        if (token.tokenType == Tokens.COMMA) {
            read();

            continue;
        }

        break;
    }
......
}

In org.hsqldb.result.Result,
public void write(SessionInterface session, DataOutputStream dataOut,
RowOutputInterface rowOut) throws IOException {
......
parameterMetaData.write(rowOut);
......
}
The sensitive information (rowOut) may be leaked.
We may be able to add control on them.

Discussion

  • Xiaoqin Fu

    Xiaoqin Fu - 2020-12-21

    Should I open a PR for it?

     
  • Fred Toussi

    Fred Toussi - 2020-12-21

    Hi Xiaoqin, you need to explain how the sensitive information (in this case rowOut) may be leaked.

     
  • Fred Toussi

    Fred Toussi - 2021-03-07
    • status: open --> closed-rejected
    • assigned_to: Fred Toussi
     
  • Fred Toussi

    Fred Toussi - 2021-03-07

    This ticket is not clear.

     

Log in to post a comment.