Menu

#1594 Sensitive information may be leaked in condlPrint of org.hsqldb.cmdline.SqlFile

version 2.5.x
closed-rejected
None
5
2021-03-07
2020-10-21
Xiaoqin Fu
No

In org.hsqldb.cmdline.SqlFile,
public String streamToString(InputStream is, final String cs)
throws IOException {
while (bytesread < ba.length &&
(retval = is.read(
ba, bytesread, ba.length - bytesread)) > 0) {
bytesread += retval;
}
}
......
private void condlPrint(final String s, final boolean printHtml) {
if ((printHtml && !htmlMode) || (htmlMode && !printHtml)) return;

    if (shared.psStd != null) shared.psStd.print(s);

    if (pwQuery != null) {
        pwQuery.print(s);
        pwQuery.flush();
    }
}

The sensitive information (String s) may be leaked.
We may be able to add control on it.

Discussion

  • Xiaoqin Fu

    Xiaoqin Fu - 2020-12-21

    Should I open a PR for it?

     
  • Fred Toussi

    Fred Toussi - 2021-03-07
    • status: open --> closed-rejected
    • assigned_to: Fred Toussi
     
  • Fred Toussi

    Fred Toussi - 2021-03-07

    This ticket is not clear.

     

Log in to post a comment.

MongoDB Logo MongoDB