Re: [Housebot-developers] SF.net SVN: housebot: [454]trunk/housebot/src

[Jason H. <jas...@gm...>]

I've tried to take a critical eye at all of this, including call graphs, 
etc...  I think most of the GTP commands in src/brains.cpp are not 
problematic.  Only the undo looks questionable.  I agree that the line 
commented out in r287 should be restored.  There's also one from r333 (I 
think that's what it was) that fragmented the undo functionality.  I've 
restored it to its original form but I think some serious review of undo 
should be done.

Please review and make sure you agree.  I looked in detail at 
SetBoardSize, ApplyGameTree, "load sgf" (forgot the name), and GTPUndo.  
I think all of those now work correctly (or at least without problems).

Phil G wrote:
> Jason wrote:
> > Yes, I'd like to know the details on the memory corruption.  I can't
> > create/consider alternate solutions if I don't know what's going wrong.
> The problem was introduced in R287. This is the revision where 
> you introduced boost functions to GTP.