[HAPI-devel] PipeParser.parseCriticalResponseData() does not return message version

[Rick R. <ric...@fo...>]

Hi,

I've been digging through the failure handling of HAPI and found a
situation where HAPI replies with an incorrect version ID.

If Responder.processMessage() cannot parse the incoming message, it will
call parser.getCriticalResponseData(). The PipeParser implementation of
this method will parse the version, but does not set it on the new msh.
Therefore DefaultApplication.makeAck() (called from
Responder.logAndMakeErrorMessage()) will just put "2.4" in the response.

I can make a patch for PipeParser.getCriticalResponseData(), but I'm not
sure if I should add an extra Terser.set() call, or if the
Parser.makeControlMSH() call is responsible for setting this. Some help
would be appreciated.

If you need any more information, don't hesitate to contact me.


B.T.W.: What's the process around submitting patches? Can I assume that
a patch, like the one I submitted to this list yesterday, will make it
into the code?

Rick Riemer
software engineer - forcare

phone: +31 (30) 699 1930
mailto:ric...@fo...
website: http://www.forcare.nl

"The good thing about standards is that there are so many to choose
from." (A. Tanenbaum, Computer Networks)