From: <leg...@at...> - 2003-12-27 07:09:25
|
The following comment has been added to this issue: Author: tom quas Created: Sat, 27 Dec 2003 1:08 AM Body: Max, I checked the source code and stumbled over that ugly Thread.currentThread()... statement. I could of courseuse it, however, what I'm saying is that the API is much more convenient to clients if you leave the old method in. An alternative would be to provide addJar( InputStream) so that one can easily do a X.class.getResourceAsStream(). This is the way to get resources from a WAR or EAR; generating a File object unnecessarily complicates things for the client. Please reconsider your design decision. Max' response: I follow ya', but i think the reason we deprecated it is that the method is not "safe" - it is not gauranteed that you can getFile() a jar via the classloader. And thus, if the user want uglinees then the user get it very explicitly ;) --------------------------------------------------------------------- View the issue: http://opensource.atlassian.com/projects/hibernate/secure/ViewIssue.jspa?key=HB-580 Here is an overview of the issue: --------------------------------------------------------------------- Key: HB-580 Summary: Undo deprecation of Configuration.addJar(String) Type: Improvement Status: Closed Priority: Critical Resolution: WON'T FIX Project: Hibernate2 Components: core Versions: 2.1.1 Assignee: Reporter: tom quas Created: Fri, 26 Dec 2003 3:51 PM Updated: Sat, 27 Dec 2003 1:08 AM Environment: API Description: I just realized that Configuration.addJar( String filename ) has been deprecated. I regularly use it to load mappings from the classpath. Could you please leave it in for convenience? --------------------------------------------------------------------- JIRA INFORMATION: This message is automatically generated by JIRA. If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira |