[Hibernate-issues] [Hibernate-JIRA] Closed: (HB-449) ScrollableResults setRowNumber()

[<leg...@at...>]

Message:

   The following issue has been closed.

   Resolver: Gavin King
       Date: Tue, 4 Nov 2003 2:45 AM

Thanks. Fixed.
---------------------------------------------------------------------
View the issue:

  http://opensource.atlassian.com/projects/hibernate/secure/ViewIssue.jspa?key=HB-449


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: HB-449
    Summary: ScrollableResults setRowNumber()
       Type: Patch

     Status: Closed
   Priority: Minor
 Resolution: FIXED

    Project: Hibernate2
 Components: 
             core
   Fix Fors:
             2.1 rc1
   Versions:
             2.1 beta 5

   Assignee: 
   Reporter: Martin Priekopa

    Created: Mon, 3 Nov 2003 8:10 AM
    Updated: Tue, 4 Nov 2003 2:45 AM

Description:
I think that implementation of ScrollableResultsImpl method:
public boolean setRowNumber(int rowNumber) throws HibernateException {
	if (rowNumber>0) rowNumber--;
	try {
		return rs.absolute(rowNumber);
	}
	catch (SQLException sqle) {
		throw new JDBCException(sqle);
	}
}

should IMHO look like this one:
public boolean setRowNumber(int rowNumber) throws HibernateException {
	if (rowNumber>0) rowNumber++;
	try {
		return rs.absolute(rowNumber);
	}
	catch (SQLException sqle) {
		throw new JDBCException(sqle);
	}
}

Or if you want to be java.sql.ResultSet compatible, both setRowNumber and getRowNumber should be wrappers only.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira