[Hibernate-issues] [Hibernate-JIRA] Commented: (HB-424) Exception wrappers should not add a message

[<leg...@at...>]

The following comment has been added to this issue:

     Author: John Kristian
    Created: Mon, 27 Oct 2003 2:19 PM
       Body:
It's OK with me that Hibernate won't change.  I already have code that works around it; it wasn't hard to write and I don't expect it will be hard to maintain.  Let's go work on something else that matters more.  But I can't resist these parting shots:

No, java.lang.Throwable doesn't implement org.apache.commons.lang.exception.Nestable.

It's true that 'instanceof Nestable' is not a reliable factor for deciding whether an exception is a wrapper.  But that's a bug, from my point of view.  Higher-level code needs to remove wrappers.  It would be better if the wrappers helped with this.

One can tell whether the exception occurred in a callback or validator by looking at the wrapper class and/or stack trace.  That's enough for me; I don't feel a need to repeat the same fact in the message.  I prefer a message that's meaningful and interesting to an end user or high level caller.
---------------------------------------------------------------------
View the issue:

  http://opensource.atlassian.com/projects/hibernate/secure/ViewIssue.jspa?key=HB-424


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: HB-424
    Summary: Exception wrappers should not add a message
       Type: Patch

     Status: Unassigned
   Priority: Minor

    Project: Hibernate2
 Components: 
             core
   Versions:
             2.1 beta 4

   Assignee: 
   Reporter: John Kristian

    Created: Thu, 23 Oct 2003 7:39 PM
    Updated: Thu, 23 Oct 2003 7:40 PM

Description:
The attached patch would be an improvement, from my point of view.

Exception classes that merely wrap another exception should not add anything to the message.  One reason is to simplify the implementation of code like this, which aims to remove such wrappers:

if (t instanceof Nestable || t instanceof InvocationTargetException || t instanceof UndeclaredThrowableException) {
    cause = t.getCause();
    if (cause != null) {
        String message = t.getMessage();
        if (message != null && message.length() > 0
            && ! message.equals(cause.getMessage()))
        {
            return t;
        }
    }
} else if (t instanceof etc...

Such code need not require special cases for Hibernate exceptions, if they refrain from adding to the message (as in the attached patch).


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira