[Hibernate-issues] [Hibernate-JIRA] Commented: (HB-424) Exception wrappers should not add a message

[<leg...@at...>]

The following comment has been added to this issue:

     Author: Max Rydahl Andersen
    Created: Mon, 27 Oct 2003 1:41 PM
       Body:
eh - HibernateException is Nestable and in JDK 1.4 ALL throwables is by default nestable...so, being Nestable (or a JDK 1.4. throwable) is not anything you can use to "detect" a wrapper exception.

Similarily, you cannot just use the rule about "if the message is equals to the lower exception" to detect a wrapper....that you should use the actual type - that's the only mechanism we have available.

Because then it would be a very explicit and "trackable" decision ;)

...but we won't change this in Hibernate since NOT adding something to the message is also bad since it makes it impossible to distinguish from the nested exception message - and that is worse in my book ;)
---------------------------------------------------------------------
View the issue:

  http://opensource.atlassian.com/projects/hibernate/secure/ViewIssue.jspa?key=HB-424


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: HB-424
    Summary: Exception wrappers should not add a message
       Type: Patch

     Status: Unassigned
   Priority: Minor

    Project: Hibernate2
 Components: 
             core
   Versions:
             2.1 beta 4

   Assignee: 
   Reporter: John Kristian

    Created: Thu, 23 Oct 2003 7:39 PM
    Updated: Thu, 23 Oct 2003 7:40 PM

Description:
The attached patch would be an improvement, from my point of view.

Exception classes that merely wrap another exception should not add anything to the message.  One reason is to simplify the implementation of code like this, which aims to remove such wrappers:

if (t instanceof Nestable || t instanceof InvocationTargetException || t instanceof UndeclaredThrowableException) {
    cause = t.getCause();
    if (cause != null) {
        String message = t.getMessage();
        if (message != null && message.length() > 0
            && ! message.equals(cause.getMessage()))
        {
            return t;
        }
    }
} else if (t instanceof etc...

Such code need not require special cases for Hibernate exceptions, if they refrain from adding to the message (as in the attached patch).


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira