[Hibernate-issues] [Hibernate-JIRA] Commented: (HB-383) websphere 5 transaction manager lookup

[<leg...@at...>]

The following comment has been added to this issue:

     Author: Daniel Bradby
    Created: Thu, 9 Oct 2003 12:33 AM
       Body:
The original patch did actually fix this, but it seems a small refactor actually broke it.

WAS5 does still include JTSXA on it's classpath and is still the actual implementation of JTA TransactionManager, but WAS5 has added on top of this (and WAS4) TransactionManagerFactory. This class uses a property (com.ibm.ws.transaction.WSTxManager=com.ibm.ejs.jts.jta.JTSXA
) to determine which JTA TransactionManager impl to use. 

I would suggest we move the lookup of the Websphere 5 class first and then on the Exception lookup the WAS 4 one if needed. The result of either will then have the same method name.

I have tested this with WAS5 ... and I suppose I can test it on WAS4 unless someone can go so quickly.
---------------------------------------------------------------------
View the issue:

  http://opensource.atlassian.com/projects/hibernate/secure/ViewIssue.jspa?key=HB-383


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: HB-383
    Summary: websphere 5 transaction manager lookup
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: Hibernate2
 Components: 
             core
   Versions:
             2.1 beta 4

   Assignee: 
   Reporter: Edina Pimp

    Created: Tue, 7 Oct 2003 11:54 AM
    Updated: Tue, 7 Oct 2003 11:54 AM
Environment: WebSphere Platform 5.0 [BASE 5.0.2]; Win2k; WSAD; JDK1.3.1

Description:
Newest version of the WebSphereTransactionManagerLookup fails under WebSphere 5.  Class com.ibm.ejs.jts.jta.JTSXA - which is the default class - remains available in the classpath so it's found and Hibernate assumes a WAS4 environment.

When 'getTransactionManager' is invoked on the WAS5 version of JTSXA, a NoSuchMethod exception is thrown, caught, and rethrown as a HibernateException.  The correct method is instance().

This worked in 2.1b3 because the exception handling just happened to line up the right way.

Maybe it's reasonable to break out different WebSphere4TransactionManagerLookup and WebSphere5TransactionManagerLookup classes, ugly as it sounds.

 


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira