[Hibernate-issues] [Hibernate-JIRA] Commented: (HB-188) Code generation for map is broken

[<leg...@at...>]

The following comment has been added to this issue:

     Author: Max Rydahl Andersen
    Created: Sun, 13 Jul 2003 1:47 PM
       Body:
That is already fixed in CVS (is it not ?)
---------------------------------------------------------------------
View the issue:

  http://opensource.atlassian.com/projects/hibernate/secure/ViewIssue.jspa?key=HB-188


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: HB-188
    Summary: Code generation for map is broken
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: Hibernate2
 Components: 
             toolset
   Versions:
             2.1
             2.0 final
             2.0.1
             2.0.2

   Assignee: 
   Reporter: Georg Schneemayer

    Created: Sun, 13 Jul 2003 12:43 PM
    Updated: Sun, 13 Jul 2003 12:43 PM
Environment: all

Description:
Problem:

The check for a sorted Collection in the class net.sf.hibernate.tool.hbm2java.ClassMapping in line 506 is broken for map Elements. It assumes that the sort attribute is defined for maps. But the sort attribute is optional for the map element according to the Hibernate Mapping DTD. (For the set element it is defined with the default value of "unsorted" by the DTD.)

Solution:

change DTD: 
235 <!ATTLIST map sort CDATA #IMPLIED>
->
235 <!ATTLIST map sort CDATA "unsorted">

or

change net.sf.hibernate.tool.hbm2java.ClassMapping:
506 if (!"unsorted".equals(collection.getAttributeValue("sort"))) {
->
506 String sort = collection.getAttributeValue("sort");
507 if ((sort != null)&&
        (!"unsorted".equals(sort))) {



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira