[Hibernate-issues] [Hibernate-JIRA] Closed: (HB-127) CounterGenerator Bug

[<leg...@at...>]

Message:

   The following issue has been closed.

   Resolver: Gavin King
       Date: Tue, 17 Jun 2003 5:47 AM

CounterGenerator was not a good implementation. I have deprecated it in favor of IncremementGenerator.
---------------------------------------------------------------------
View the issue:

  http://opensource.atlassian.com/projects/hibernate/secure/ViewIssue.jspa?key=HB-127


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: HB-127
    Summary: CounterGenerator Bug
       Type: Bug

     Status: Closed
   Priority: Major
 Resolution: FIXED

    Project: Hibernate2
 Components: 
             core
   Fix Fors:
             2.0.1
   Versions:
             2.0 final

   Assignee: Gavin King
   Reporter: Maks Glukhovtsev

    Created: Tue, 10 Jun 2003 8:23 AM
    Updated: Tue, 17 Jun 2003 5:47 AM
Environment: Sybase 11.9.2

Description:
When using "vm" generator, experiencing problem of trying to insert a non-unique value of PK. 

When sleep() inserted in generate() (just for test purposes), problem disappeared.

So, with minor changes:

	private static long counter =  0;

	protected long getCount() {
		synchronized(CounterGenerator.class) {
			if (counter==0) counter=System.currentTimeMillis();
			return counter++;
		}
	}

	public Serializable generate(SessionImplementor cache, Object obj) {
		return new Long( getCount() );
	}

problem has been resolved.

please.. do something more serious about it :)




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira