RE: [Hibernate-devel] not so fast! :)

[Gavin_King/Cirrus%<CI...@ci...>]

> Hey, these would only be embarrassing if they were caught after
> v1.0!

Yeah, but I'm kinda hoping 1.0 is fairly close now.....

> I figured the external connection scenario wasn't being widely
> used.  I probably wouldn't be using it either, except that I'm
> integrating into an existing system, and I thought it would be
> a good idea to share the same connection pool as the rest of
> the system.

Exactly the kind of usage I had in mind :)

> > I guess this means I have to do another release real soon ... but
> > not today.

> I agree it's not that urgent, unless you're aware of anyone
> embedding the code into heart-lung machines as we speak... :)

heh :) heart-lung machine programmers can use the version in CVS

> I was thinking about that: testing the finalize issue would be
> tricky, since the symptoms could range from benign to unpredictable.
> I think this particular issue would be handled better by some
> additional checks (or assertions).  One would be inside
> RelationalDatabaseSession.finalize:

Okay, I integrated that...

> Another place to check for and warn about a non-null connection
> would be inside cleanup(), i.e.

probably not necessary - that stuffs better done in the tests
(as you noted).

Unfortunately the various possible failure modes make this section
of the code (ie. Session.close() + the deprecated versions) very
fiddly and difficult to fully test.

> My first bug, with the parameters swapped around, is easier to unit
> test for.  I'll see if I can put something together after I've
> installed the code I'm currently working on.  (Unit test after
> release, XLP - Xtremely Lazy Programming?)

:)

Anton, if you send me your sourceforge username, I will give you CVS
access.