Re: [Hibernate-devel] database native keys

[Christoph S. <ch...@sc...>]

Hi Gavin!

thanks for your feedback!

Gavin_King/Cirrus%CI...@ci... wrote:

>Cool! Sounds great.
>
>>* Added a public boolean isNative function to the IDGenerator interface.
>>All old generators return false here, the NativeGenerator returns true.
>>
>
>I'm wondering if this is the best place for this flag. Can't see how its
>used but I would have been tempted to plonk it on ClassPersister instead.
>My reasoning is that there will only ever be that one single implementation
>of IDGenerator where it returns false. By adding the method to IDGenerator
>we force every future implementation of the interface to declare a method
>that does the exact same thing.
>
There needs to be a way to tell hibernate to use the native key 
generator for a table. And the code needs to check for it.  Do you think 
its better to compare the class of the keygenerator?

>Doesn't someone out there need BLOB support?? This can't be part of the
>"official" API because some priority target platforms (Postgres) don't
>have BLOBS yet. Still, I would happily distribute BLOBType with the rest
>of the project....
>
What? no blobs? :P
how does postgres handle binary data then?

>
>
>I think what I just did is called "going off on a tangent".
>
>Anyways my point was lets try and keep IDGenerator and Dialect as trivial
>as possible. If possible. Cool?
>

I will have to add two things to Dialect: one for the identity select, 
and one for the creation of the identity column.

Tell me what you think, and I'll go ahead :)

regards
 chris