[Hibernate-issues] [Hibernate-JIRA] Created: (HHH-1959) Callable update/insert/delete statements should not force rowcount out parameter in AbstractEntityPersister

[Brad L V. (JIRA) <no...@at...>]

Callable update/insert/delete statements should not force rowcount out parameter in AbstractEntityPersister
-----------------------------------------------------------------------------------------------------------

         Key: HHH-1959
         URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1959
     Project: Hibernate3
        Type: Bug

    Versions: 3.2.0.cr3    
    Reporter: Brad L Vandermoon


It appears as though callable statements in DB2 for AbstractCollectionPersister was resolved under HHH-1792; however, the AbstractEntityPersister was not changed to use the new Expectations class instead of the check function.    The check function call in "delete(final Serializable id, final Object version, final int j, final Object object, final String sql, final SessionImplementor session) throws HibernateException" and  "update(final Serializable id, final Object[] fields, final Object[] oldFields, final Object rowId, final boolean[] includeProperty, final int j, final Object oldVersion, final Object object, final String sql, final SessionImplementor session) throws HibernateException"appears to need to replace with a call to expectation.verifyOutcome().  

The insert function does not currently call check.  Should it call expectation.verifyOutcome() to be consistent with delete and update implementations. 


Snippet of my change for update(final Serializable id, final Object[] fields, final Object[] oldFields, final Object rowId, final boolean[] includeProperty, final int j, final Object oldVersion, final Object object, final String sql, final SessionImplementor session) throws HibernateException: 
				if ( useBatch ) {
					session.getBatcher().addToBatch( expectation );
					return true;
				}
				else {
				    expectation.verifyOutcome( update.executeUpdate(), update, -1 );
				    return true;
				}



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira