[Hibernate-issues] [Hibernate-JIRA] Created: (HHH-1918) enable non-hilo identity generation in DerbyDialect

[Adrian M. (JIRA) <no...@at...>]

enable non-hilo identity generation in DerbyDialect
---------------------------------------------------

         Key: HHH-1918
         URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1918
     Project: Hibernate3
        Type: Patch

 Environment: 3.2.0.rc2, Derby
    Reporter: Adrian Moos
    Priority: Minor


> From: hib...@li...
> [mailto:hib...@li...]On Behalf Of Max
> Rydahl Andersen
> Sent: Mittwoch, 12. Juli 2006 12:20
> To: hib...@li...
> Cc: sk...@us...
> Subject: Re: [Hibernate] native id generation in DerbyDialect
> 
> 
> The DerbyDialect was contributed by an external party.
> 
> If you have a better implementation patches are welcome in our jira.

See below. Knowing little about derby I am not sure 100% sure it is better, but it appears to be.

> But it would be nice to know why the external contributor choose
> to use tablehilo as the default and have that "fun" 
> identitycolumnstring.

Indeed. Alas, he hasn't replied ...

Patch: Delete
	public Class getNativeIdentifierGeneratorClass() {
		return TableHiLoGenerator.class;
	}
from org.hibernate.dialect.DerbyDialect

QA: My test application using sequence identifier generation works correctly. Identity generation not tested, but as the contributor provided an improved query string this should be ok.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira