From: Steve E. (JIRA) <no...@at...> - 2006-01-23 15:24:12
|
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1083?page=comments#action_21739 ] Steve Ebersole commented on HHH-1083: ------------------------------------- Well, if we do this I'd see it split into (1) the contract interface and (2) a BasicRenderer implementation that would actually reside in the core. And by BasicRenderer here I mean exactly what the current rendering does (MySQL would have an option between one of two BasicRenderers). An example of something I *do not* want here is a Velocity-based rendering, as it simply adds another unneeded dependency for the core. > Customization of CREATE TABLE with storage clause etc. > ------------------------------------------------------ > > Key: HHH-1083 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1083 > Project: Hibernate3 > Type: New Feature > Reporter: Christian Bauer > Priority: Minor > Fix For: 3.1.2 > > > Currently Hibernate features a hotfix for the MySQLInnoDBDialect: > public String getTableTypeString() { > return " type=InnoDB"; > } > However, this is not the only appendix that is useful for CREATE TABLE. We should do several things: > - allow appendix for CREATE INDEX, for example, to define the tablespace > - pass in additional arguments to getTableTypeString(), such as tableName, schemaName, catalogName - for example, to allow custom Dialects to return different tablespaces for particular tables > - probably rename the getTableTypeString() method to getTableAppendixString() and getIndexAppendixString() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |