Re: [Hibernate] Connection Handling in Isolater

[Steve E. <ste...@jb...>]

Yep.  This has already been fixed for almost two months now in SVN ;)

-----Original Message-----
From: hib...@li...
[mailto:hib...@li...] On Behalf Of
ja...@he...
Sent: Thursday, July 20, 2006 8:35 AM
To: hib...@li...
Cc: ja...@he...
Subject: [Hibernate] Connection Handling in Isolater

Hi all,

I think org.hibernate.engine.transaction.Isolater is not handling
connections properly:

The method JdbcDelegate is currently implemented as follows:

	public static class JdbcDelegate implements Delegate {
	        ...
		public void delegateWork(IsolatedWork work) throws
HibernateException {
			Connection connection =3D null;
			try {
				connection =3D
session.getBatcher().openConnection();
				...
			}
			  ...
			}
			finally {
				if ( wasAutoCommit ) {
					try {
=09
connection.setAutoCommit( true );
					}
					catch( Throwable ignore ) {
						log.trace( "was unable
to reset connection back to auto-commit" );
					}
=09
session.getBatcher().closeConnection( connection );
				}
			}
		}
	}


This means that the connection will only be closed if
wasAutoCommit=3D=3Dtrue but I think it should be closed in any =
circumstance:


	public static class JdbcDelegate implements Delegate {
	        ...
		public void delegateWork(IsolatedWork work) throws
HibernateException {
			Connection connection =3D null;
			try {
				connection =3D
session.getBatcher().openConnection();
				...
			}
			  ...
			}
			finally {
				if ( wasAutoCommit ) {
					try {
=09
connection.setAutoCommit( true );
					}
					catch( Throwable ignore ) {
						log.trace( "was unable
to reset connection back to auto-commit" );
					}
				}
				session.getBatcher().closeConnection(
connection );
			}
		}
	}

What do you think ?=20

--=20


"Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ...
Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail

------------------------------------------------------------------------
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share
your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D=
DEVDE
V
_______________________________________________
hibernate-devel mailing list
hib...@li...
https://lists.sourceforge.net/lists/listinfo/hibernate-devel