Menu
▾
▴
[Hibernate-issues] [Hibernate-JIRA] Commented: (HB-1064) CGLIB classes loaded even when reflection optimizer disabled
|
From: <leg...@at...> - 2004-07-06 06:50:40
|
The following comment has been added to this issue:
Author: Tim Motika
Created: Tue, 6 Jul 2004 2:10 AM
Body:
It still breaks it, and it's still an issue.
Rather 1 of these forms of code slop is the excuse:
1. Environment.useReflectionOptimization() which should be in Configuration, but will take time to move there.
2. FastClass.create() which is invoked unnecessarily, which would not matter, but for breaking module encapsulation.
3. FastClass breaks webapp encapsulation by requiring system classpath modifications through Class.forName() most likely.
If you are running a webapp and can't modify the system CLASSPATH you are mostly SOL.
This wasted 40 minutes of my time doing manual information search, plus other people's time past (it was reported on a forum), and future. Not to mention all the other issues I've tripped over. Thank god for the painfully slow non-searchable web forums.
So is 2 minutes more important than hours of other people's time?
---------------------------------------------------------------------
View this comment:
http://opensource.atlassian.com/projects/hibernate/browse/HB-1064?page=comments#action_13570
---------------------------------------------------------------------
View the issue:
http://opensource.atlassian.com/projects/hibernate/browse/HB-1064
Here is an overview of the issue:
---------------------------------------------------------------------
Key: HB-1064
Summary: CGLIB classes loaded even when reflection optimizer disabled
Type: Bug
Status: Closed
Priority: Minor
Resolution: REJECTED
Original Estimate: 5 minutes
Time Spent: Unknown
Remaining: 5 minutes
Project: Hibernate2
Components:
core
Versions:
2.1.3
Assignee:
Reporter: Tim Motika
Created: Mon, 5 Jul 2004 6:35 AM
Updated: Tue, 6 Jul 2004 2:10 AM
Environment: All; ( win32 resin / issue when cglib dynamically loaded and not in system classpath, as on a webapp)
Description:
Running Hibernate from a webapp causes crash on ClassNotFoundException with the cglib
in the lib/ non-system path, even when the optimizer is turned
off, since it fails, being unable to load net.sf.cglib.reflect.FastClass for some container-related reason (CGLib is probably using Class.forName() which only loads system classes instead of getClass.getClassLoader().loadClass() ).
Container behavior aside, Hibernate is breaking encapsulation by loading cglib even when the feature is turned off, then not using it.
Suggested fix:
Only execute the calls to FastClass.create() conditionally
in these three files:
./net/sf/hibernate/persister/AbstractEntityPersister.java:756
./net/sf/hibernate/type/ComponentType.java:113
./net/sf/hibernate/util/ReflectHelper.java:156
Related: change usage of Class.forName() to getClass().getClassLoader().loadClass() in CGLIB so that the jar is
not pinned to being in the system classpath
Hrm. Environmnet is *only* used in these files to check if the optimizer is on. Seems like moving them over to configuration-based checking would be possible.
BTW, thanks for the great work on Hibernate!
Autopsy:
Stack trace, even when the optimizer has been disabled, and Environment.useReflectionOptimizer() returns false.
Error: net.sf.cglib.core.CodeGenerationException: java.lang.reflect.InvocationTargetException-->null
net.sf.cglib.core.CodeGenerationException: java.lang.reflect.InvocationTargetException-->null
at net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:208)
at net.sf.cglib.reflect.FastClass$Generator.create(FastClass.java:92)
at net.sf.cglib.reflect.FastClass.create(FastClass.java:74)
at net.sf.hibernate.persister.AbstractEntityPersister.(AbstractEntityPersister.java:756)
at net.sf.hibernate.persister.EntityPersister.(EntityPersister.java:714)
at net.sf.hibernate.persister.PersisterFactory.createClassPersister(PersisterFactory.java:42)
at net.sf.hibernate.impl.SessionFactoryImpl.(SessionFactoryImpl.java:137)
at net.sf.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:768)
at org.tlala.site.HibernateUtil.start(HibernateUtil.java:183)
at org.tlala.site.DBHome.startDB(DBHome.java:86)
at org.tlala.site.DBHome.currentSession(DBHome.java:145)
at org.tlala.site.DBHome.doBody(DBHome.java:292)
at org.tlala.site.DBHome.service(DBHome.java:215)
at org.tlala.site.DBHome.service(DBHome.java:176)
at com.caucho.server.http.FilterChainServlet.doFilter(FilterChainServlet.java:96)
at com.caucho.server.http.Invocation.service(Invocation.java:315)
at com.caucho.server.http.CacheInvocation.service(CacheInvocation.java:135)
at com.caucho.server.http.HttpRequest.handleRequest(HttpRequest.java:246)
at com.caucho.server.http.HttpRequest.handleConnection(HttpRequest.java:164)
at com.caucho.server.TcpConnection.run(TcpConnection.java:139)
at java.lang.Thread.run(Thread.java:534)
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at net.sf.cglib.core.ReflectUtils.defineClass(ReflectUtils.java:411)
at net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:195)
... 20 more
Caused by: java.lang.NoClassDefFoundError: net/sf/cglib/reflect/FastClass
at java.lang.ClassLoader.defineClass0(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:537)
... 26 more
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
|
