Menu
▾
▴
hibernate-issues
|
From: Barry K. (JIRA) <no...@at...> - 2006-05-10 23:39:10
|
EntityBinder is always auto-import
----------------------------------
Key: ANN-341
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-341
Project: Hibernate Annotations
Type: Bug
Components: binder
Versions: 3.1.0.Beta10
Reporter: Barry Kaplan
I have two classes with the same unqualified name but in different packages:
package org.opentrader.foo;
@Entity
class Order { ... }
package org.opentrader.bar;
@Entity
class Order { ... }
These classes are added using AnnotationConfiguration.addAnnotatedClass().
But when these classes are added, EntityBinder.bindEjb3Annotation will use the unqualified name as the key for storing the entity:
class EntityBinder {
...
if ( AnnotationBinder.isDefault( ejb3Ann.name() ) ) {
name = StringHelper.unqualify( annotatedClass.getName() );
}
else {
name = ejb3Ann.name();
}
...
try {
mappings.addImport( persistentClass.getEntityName(), name );
}
catch (MappingException me) {
throw new AnnotationException( "Use of the same entity name twice: " + name );
}
}
class Mappings {
public void addImport(...) {
String existing = (String) imports.put(rename, className);
}
}
When HbmBinder adds imports, it has logic to /not/ add the class using its unqualified name:
class HbmBinder.addImport() {
mappings.addImport( entity.getEntityName(), entity.getEntityName() );
if ( mappings.isAutoImport() && entity.getEntityName().indexOf( '.' ) > 0 ) {
mappings.addImport(
entity.getEntityName(),
StringHelper.unqualify( entity.getEntityName() )
);
}
}
Should not EntityBinder also explicitly support auto-import?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|
|
From: Emmanuel B. (JIRA) <no...@at...> - 2006-05-11 03:58:11
|
[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-341?page=all ] Emmanuel Bernard resolved ANN-341: ---------------------------------- Resolution: Rejected as per the spec use @entity(name="myuniquename") > EntityBinder is always auto-import > ---------------------------------- > > Key: ANN-341 > URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-341 > Project: Hibernate Annotations > Type: Bug > Components: binder > Versions: 3.1.0.Beta10 > Reporter: Barry Kaplan > > > I have two classes with the same unqualified name but in different packages: > package org.opentrader.foo; > @Entity > class Order { ... } > package org.opentrader.bar; > @Entity > class Order { ... } > These classes are added using AnnotationConfiguration.addAnnotatedClass(). > But when these classes are added, EntityBinder.bindEjb3Annotation will use the unqualified name as the key for storing the entity: > class EntityBinder { > ... > if ( AnnotationBinder.isDefault( ejb3Ann.name() ) ) { > name = StringHelper.unqualify( annotatedClass.getName() ); > } > else { > name = ejb3Ann.name(); > } > ... > try { > mappings.addImport( persistentClass.getEntityName(), name ); > } > catch (MappingException me) { > throw new AnnotationException( "Use of the same entity name twice: " + name ); > } > } > class Mappings { > public void addImport(...) { > String existing = (String) imports.put(rename, className); > } > } > When HbmBinder adds imports, it has logic to /not/ add the class using its unqualified name: > class HbmBinder.addImport() { > mappings.addImport( entity.getEntityName(), entity.getEntityName() ); > if ( mappings.isAutoImport() && entity.getEntityName().indexOf( '.' ) > 0 ) { > mappings.addImport( > entity.getEntityName(), > StringHelper.unqualify( entity.getEntityName() ) > ); > } > } > Should not EntityBinder also explicitly support auto-import? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Barry K. (JIRA) <no...@at...> - 2006-05-11 13:15:11
|
[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-341?page=comments#action_23081 ] Barry Kaplan commented on ANN-341: ---------------------------------- I could not find anything in the spec which states the default value for 'name' /must/ be the unqualified class name? Did I just miss it? Or is this is a hibernate specific decision? Do you know how it is recommended to handle the case when a product is including two thirdparty jars with conflicting unqualified @Entity's where changing the source is not an option? This is the case that I am concerned about wrt this issue. > EntityBinder is always auto-import > ---------------------------------- > > Key: ANN-341 > URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-341 > Project: Hibernate Annotations > Type: Bug > Components: binder > Versions: 3.1.0.Beta10 > Reporter: Barry Kaplan > > > I have two classes with the same unqualified name but in different packages: > package org.opentrader.foo; > @Entity > class Order { ... } > package org.opentrader.bar; > @Entity > class Order { ... } > These classes are added using AnnotationConfiguration.addAnnotatedClass(). > But when these classes are added, EntityBinder.bindEjb3Annotation will use the unqualified name as the key for storing the entity: > class EntityBinder { > ... > if ( AnnotationBinder.isDefault( ejb3Ann.name() ) ) { > name = StringHelper.unqualify( annotatedClass.getName() ); > } > else { > name = ejb3Ann.name(); > } > ... > try { > mappings.addImport( persistentClass.getEntityName(), name ); > } > catch (MappingException me) { > throw new AnnotationException( "Use of the same entity name twice: " + name ); > } > } > class Mappings { > public void addImport(...) { > String existing = (String) imports.put(rename, className); > } > } > When HbmBinder adds imports, it has logic to /not/ add the class using its unqualified name: > class HbmBinder.addImport() { > mappings.addImport( entity.getEntityName(), entity.getEntityName() ); > if ( mappings.isAutoImport() && entity.getEntityName().indexOf( '.' ) > 0 ) { > mappings.addImport( > entity.getEntityName(), > StringHelper.unqualify( entity.getEntityName() ) > ); > } > } > Should not EntityBinder also explicitly support auto-import? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Emmanuel B. (JIRA) <no...@at...> - 2006-05-11 13:51:12
|
[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-341?page=comments#action_23082 ] Emmanuel Bernard commented on ANN-341: -------------------------------------- Stated in the spec PDF Chapter 8.1 in my version. either use a fqcn in your @Entity(name) or use XML to override the mapping > EntityBinder is always auto-import > ---------------------------------- > > Key: ANN-341 > URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-341 > Project: Hibernate Annotations > Type: Bug > Components: binder > Versions: 3.1.0.Beta10 > Reporter: Barry Kaplan > > > I have two classes with the same unqualified name but in different packages: > package org.opentrader.foo; > @Entity > class Order { ... } > package org.opentrader.bar; > @Entity > class Order { ... } > These classes are added using AnnotationConfiguration.addAnnotatedClass(). > But when these classes are added, EntityBinder.bindEjb3Annotation will use the unqualified name as the key for storing the entity: > class EntityBinder { > ... > if ( AnnotationBinder.isDefault( ejb3Ann.name() ) ) { > name = StringHelper.unqualify( annotatedClass.getName() ); > } > else { > name = ejb3Ann.name(); > } > ... > try { > mappings.addImport( persistentClass.getEntityName(), name ); > } > catch (MappingException me) { > throw new AnnotationException( "Use of the same entity name twice: " + name ); > } > } > class Mappings { > public void addImport(...) { > String existing = (String) imports.put(rename, className); > } > } > When HbmBinder adds imports, it has logic to /not/ add the class using its unqualified name: > class HbmBinder.addImport() { > mappings.addImport( entity.getEntityName(), entity.getEntityName() ); > if ( mappings.isAutoImport() && entity.getEntityName().indexOf( '.' ) > 0 ) { > mappings.addImport( > entity.getEntityName(), > StringHelper.unqualify( entity.getEntityName() ) > ); > } > } > Should not EntityBinder also explicitly support auto-import? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Barry K. (JIRA) <no...@at...> - 2006-05-11 14:40:14
|
[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-341?page=comments#action_23083 ] Barry Kaplan commented on ANN-341: ---------------------------------- Yup, I missed it. Its right there in 8.1. Thanks Emmanuel. > EntityBinder is always auto-import > ---------------------------------- > > Key: ANN-341 > URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-341 > Project: Hibernate Annotations > Type: Bug > Components: binder > Versions: 3.1.0.Beta10 > Reporter: Barry Kaplan > > > I have two classes with the same unqualified name but in different packages: > package org.opentrader.foo; > @Entity > class Order { ... } > package org.opentrader.bar; > @Entity > class Order { ... } > These classes are added using AnnotationConfiguration.addAnnotatedClass(). > But when these classes are added, EntityBinder.bindEjb3Annotation will use the unqualified name as the key for storing the entity: > class EntityBinder { > ... > if ( AnnotationBinder.isDefault( ejb3Ann.name() ) ) { > name = StringHelper.unqualify( annotatedClass.getName() ); > } > else { > name = ejb3Ann.name(); > } > ... > try { > mappings.addImport( persistentClass.getEntityName(), name ); > } > catch (MappingException me) { > throw new AnnotationException( "Use of the same entity name twice: " + name ); > } > } > class Mappings { > public void addImport(...) { > String existing = (String) imports.put(rename, className); > } > } > When HbmBinder adds imports, it has logic to /not/ add the class using its unqualified name: > class HbmBinder.addImport() { > mappings.addImport( entity.getEntityName(), entity.getEntityName() ); > if ( mappings.isAutoImport() && entity.getEntityName().indexOf( '.' ) > 0 ) { > mappings.addImport( > entity.getEntityName(), > StringHelper.unqualify( entity.getEntityName() ) > ); > } > } > Should not EntityBinder also explicitly support auto-import? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X