hibernate-devel

[Hibernate] useless parameter in SecondPass interface

[Max R. A. <max...@jb...>]

Hi Emmanuel/Steve,

The fix I just did for  
http://opensource.atlassian.com/projects/hibernate/browse/HHH-1963 renders
the inheritedMetas in the SecondPass interface useless. (It is only  
relevant for HbmBinder's Collection secondpass construction anyway.

I tried to remove it but then annotations breaks.

Should we just let it stick around or remove it ?

-- 
--
Max Rydahl Andersen
callto://max.rydahl.andersen

Hibernate
ma...@hi...
http://hibernate.org

JBoss Inc
max...@jb...

Re: [Hibernate] useless parameter in SecondPass interface

[Emmanuel B. <emm...@hi...>]

I don't use them. Will I ever need to integrate them?
core CR3 is incompatible with annotations CR1 already so I guess you can 
do the change.

Max Rydahl Andersen wrote:
> Hi Emmanuel/Steve,
>
> The fix I just did for  
> http://opensource.atlassian.com/projects/hibernate/browse/HHH-1963 renders
> the inheritedMetas in the SecondPass interface useless. (It is only  
> relevant for HbmBinder's Collection secondpass construction anyway.
>
> I tried to remove it but then annotations breaks.
>
> Should we just let it stick around or remove it ?
>
>   

Re: [Hibernate] useless parameter in SecondPass interface

[Max R. A. <max...@jb...>]

On Wed, 02 Aug 2006 18:47:13 +0200, Emmanuel Bernard  
<emm...@hi...> wrote:

> I don't use them. Will I ever need to integrate them?

Maybe, but not via this parameter since it's "behavior" is tied into how  
hbmBinder process
the meta attributes.

> core CR3 is incompatible with annotations CR1 already so I guess you can  
> do the change.

Ok - i'll remove it.

/max


> Max Rydahl Andersen wrote:
>> Hi Emmanuel/Steve,
>>
>> The fix I just did for   
>> http://opensource.atlassian.com/projects/hibernate/browse/HHH-1963  
>> renders
>> the inheritedMetas in the SecondPass interface useless. (It is only   
>> relevant for HbmBinder's Collection secondpass construction anyway.
>>
>> I tried to remove it but then annotations breaks.
>>
>> Should we just let it stick around or remove it ?
>>
>>



-- 
--
Max Rydahl Andersen
callto://max.rydahl.andersen

Hibernate
ma...@hi...
http://hibernate.org

JBoss Inc
max...@jb...

Re: [Hibernate] useless parameter in SecondPass interface

[Max R. A. <max...@jb...>]

ok for me to fix the code in the metadata package too or does it need to  
stay compatible to the old version ?

/max

> I don't use them. Will I ever need to integrate them?
> core CR3 is incompatible with annotations CR1 already so I guess you can  
> do the change.
>
> Max Rydahl Andersen wrote:
>> Hi Emmanuel/Steve,
>>
>> The fix I just did for   
>> http://opensource.atlassian.com/projects/hibernate/browse/HHH-1963  
>> renders
>> the inheritedMetas in the SecondPass interface useless. (It is only   
>> relevant for HbmBinder's Collection secondpass construction anyway.
>>
>> I tried to remove it but then annotations breaks.
>>
>> Should we just let it stick around or remove it ?
>>
>>



-- 
--
Max Rydahl Andersen
callto://max.rydahl.andersen

Hibernate
ma...@hi...
http://hibernate.org

JBoss Inc
max...@jb...