Menu
▾
▴
hibernate-devel
|
From: Steve E. <ste...@jb...> - 2006-05-10 14:50:04
|
Sorry, my fault. I forgot that we added that call to your stuff. =20 We really need this changed though to properly allow for (1) classic aggregation registration and (2) better user function registration.=20 =20 The other thing I could do is add back the old signature which would only be for your use, and which would not account for user-registered functions (planned feature). That work? =20 ________________________________ From: hib...@li... [mailto:hib...@li...] On Behalf Of Emmanuel Bernard Sent: Wednesday, May 10, 2006 9:05 AM To: Hibernate development Subject: [Hibernate] Issue with pluggable functions =20 public static String renderWhereStringTemplate(String sqlWhereString, Dialect dialect, SQLFunctionRegistry functionRegistry)=20 Breaks binary compatibility with Hibernate Annotations 3.2.0.CR1 |
|
From: Max R. A. <max...@jb...> - 2006-05-10 14:57:19
|
On Wed, 10 May 2006 16:45:02 +0200, Emmanuel Bernard <emm...@jb...> wrote: > Yes at least we must not release another core version until we find a > solution Again why are you using this function at *config* time ? What is this feature that is in annotations and not in the core ? Anyhow a workaround is: formulaString = Template.renderWhereStringTemplate( formulaString, "$alias$", new HSQLDialect(), new SQLFunctionRegistry( new HSQLDialect(), Collections.EMPTY_LIST) ); which is just as much a hack like the existing dummy new HSQLDialect() you have ;) /max > > > -----Original Message----- > From: Max Rydahl Andersen <max...@jb...> > To: Emmanuel Bernard <emm...@hi...>; Hibernate development > <hib...@li...> > Sent: Wed May 10 09:24:46 2006 > Subject: Re: [Hibernate] Issue with pluggable functions > > > ...so I apparently did not have the latest-latest of annotations checkked > out when i added this; sorry! > > Is it a show-stopper ? > >> public static String renderWhereStringTemplate(String sqlWhereString, >> Dialect dialect, *SQLFunctionRegistry functionRegistry*) >> >> >> Breaks binary compatibility with Hibernate Annotations 3.2.0.CR1 > > > -- -- Max Rydahl Andersen callto://max.rydahl.andersen Hibernate ma...@hi... http://hibernate.org JBoss Inc max...@jb... |
|
From: Steve E. <ste...@jb...> - 2006-05-10 15:05:39
|
We used to implement a required feature of EJB3 that really does not make much sense ;) It allows you to have a <map></many-to-many></map> structure where the map-key comes from the target entity table (i.e. *not* the association table). At any rate, it probably will be added to core at some point; but it is very intensive to implement properly there, so we did it this way for the sake of getting the latest releases out. -----Original Message----- From: hib...@li... [mailto:hib...@li...] On Behalf Of Max Rydahl Andersen Sent: Wednesday, May 10, 2006 9:57 AM To: Emmanuel Bernard; emm...@hi...; hib...@li... Subject: Re: [Hibernate] Issue with pluggable functions On Wed, 10 May 2006 16:45:02 +0200, Emmanuel Bernard =20 <emm...@jb...> wrote: > Yes at least we must not release another core version until we find a > solution Again why are you using this function at *config* time ? What is this feature that is in annotations and not in the core ? Anyhow a workaround is: formulaString =3D Template.renderWhereStringTemplate( formulaString, =20 "$alias$", new HSQLDialect(), new SQLFunctionRegistry( new HSQLDialect(), =20 Collections.EMPTY_LIST) ); which is just as much a hack like the existing dummy new HSQLDialect() you =20 have ;) /max > > > -----Original Message----- > From: Max Rydahl Andersen <max...@jb...> > To: Emmanuel Bernard <emm...@hi...>; Hibernate development =20 > <hib...@li...> > Sent: Wed May 10 09:24:46 2006 > Subject: Re: [Hibernate] Issue with pluggable functions > > > ...so I apparently did not have the latest-latest of annotations checkked > out when i added this; sorry! > > Is it a show-stopper ? > >> public static String renderWhereStringTemplate(String sqlWhereString, >> Dialect dialect, *SQLFunctionRegistry functionRegistry*) >> >> >> Breaks binary compatibility with Hibernate Annotations 3.2.0.CR1 > > > --=20 -- Max Rydahl Andersen callto://max.rydahl.andersen Hibernate ma...@hi... http://hibernate.org JBoss Inc max...@jb... ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D= 121642 _______________________________________________ hibernate-devel mailing list hib...@li... https://lists.sourceforge.net/lists/listinfo/hibernate-devel |
|
From: Max R. A. <max...@jb...> - 2006-05-10 15:27:41
|
okey - sounds like a crazy feature ;) So the fix is to apply the "hack" I wrote in the last email; it will be in the same league as what is done currently for this map/many-to-many. /max > We used to implement a required feature of EJB3 that really does not > make much sense ;) It allows you to have a <map></many-to-many></map> > structure where the map-key comes from the target entity table (i.e. > *not* the association table). > > At any rate, it probably will be added to core at some point; but it is > very intensive to implement properly there, so we did it this way for > the sake of getting the latest releases out. > > -----Original Message----- > From: hib...@li... > [mailto:hib...@li...] On Behalf Of Max > Rydahl Andersen > Sent: Wednesday, May 10, 2006 9:57 AM > To: Emmanuel Bernard; emm...@hi...; > hib...@li... > Subject: Re: [Hibernate] Issue with pluggable functions > > On Wed, 10 May 2006 16:45:02 +0200, Emmanuel Bernard > <emm...@jb...> wrote: > >> Yes at least we must not release another core version until we find a > >> solution > > Again why are you using this function at *config* time ? > What is this feature that is in annotations and not in the core ? > > Anyhow a workaround is: > > formulaString = Template.renderWhereStringTemplate( formulaString, > "$alias$", new HSQLDialect(), new SQLFunctionRegistry( new > HSQLDialect(), > Collections.EMPTY_LIST) ); > > which is just as much a hack like the existing dummy new HSQLDialect() > you > have ;) > > /max > > >> >> >> -----Original Message----- >> From: Max Rydahl Andersen <max...@jb...> >> To: Emmanuel Bernard <emm...@hi...>; Hibernate development >> <hib...@li...> >> Sent: Wed May 10 09:24:46 2006 >> Subject: Re: [Hibernate] Issue with pluggable functions >> >> >> ...so I apparently did not have the latest-latest of annotations > checkked >> out when i added this; sorry! >> >> Is it a show-stopper ? >> >>> public static String renderWhereStringTemplate(String sqlWhereString, >>> Dialect dialect, *SQLFunctionRegistry functionRegistry*) >>> >>> >>> Breaks binary compatibility with Hibernate Annotations 3.2.0.CR1 >> >> >> > > > -- -- Max Rydahl Andersen callto://max.rydahl.andersen Hibernate ma...@hi... http://hibernate.org JBoss Inc max...@jb... |
|
From: Steve E. <ste...@jb...> - 2006-05-10 15:32:13
|
That still creates an incompatibility because the annotations code must change to use the new signature. I'll just add back the old signature to Template and, yes, it'll do what you just said. -----Original Message----- From: Max Andersen=20 Sent: Wednesday, May 10, 2006 10:27 AM To: Steve Ebersole; hib...@li... Subject: Re: [Hibernate] Issue with pluggable functions okey - sounds like a crazy feature ;) So the fix is to apply the "hack" I wrote in the last email; it will be in the same league as what is done currently for this =20 map/many-to-many. /max > We used to implement a required feature of EJB3 that really does not > make much sense ;) It allows you to have a <map></many-to-many></map> > structure where the map-key comes from the target entity table (i.e. > *not* the association table). > > At any rate, it probably will be added to core at some point; but it is > very intensive to implement properly there, so we did it this way for > the sake of getting the latest releases out. > > -----Original Message----- > From: hib...@li... > [mailto:hib...@li...] On Behalf Of Max > Rydahl Andersen > Sent: Wednesday, May 10, 2006 9:57 AM > To: Emmanuel Bernard; emm...@hi...; > hib...@li... > Subject: Re: [Hibernate] Issue with pluggable functions > > On Wed, 10 May 2006 16:45:02 +0200, Emmanuel Bernard > <emm...@jb...> wrote: > >> Yes at least we must not release another core version until we find a > >> solution > > Again why are you using this function at *config* time ? > What is this feature that is in annotations and not in the core ? > > Anyhow a workaround is: > > formulaString =3D Template.renderWhereStringTemplate( formulaString, > "$alias$", new HSQLDialect(), new SQLFunctionRegistry( new > HSQLDialect(), > Collections.EMPTY_LIST) ); > > which is just as much a hack like the existing dummy new HSQLDialect() > you > have ;) > > /max > > >> >> >> -----Original Message----- >> From: Max Rydahl Andersen <max...@jb...> >> To: Emmanuel Bernard <emm...@hi...>; Hibernate development >> <hib...@li...> >> Sent: Wed May 10 09:24:46 2006 >> Subject: Re: [Hibernate] Issue with pluggable functions >> >> >> ...so I apparently did not have the latest-latest of annotations > checkked >> out when i added this; sorry! >> >> Is it a show-stopper ? >> >>> public static String renderWhereStringTemplate(String sqlWhereString, >>> Dialect dialect, *SQLFunctionRegistry functionRegistry*) >>> >>> >>> Breaks binary compatibility with Hibernate Annotations 3.2.0.CR1 >> >> >> > > > --=20 -- Max Rydahl Andersen callto://max.rydahl.andersen Hibernate ma...@hi... http://hibernate.org JBoss Inc max...@jb... |
|
From: Steve E. <ste...@jb...> - 2006-05-10 16:53:12
|
yep -----Original Message----- From: Emmanuel Bernard=20 Sent: Wednesday, May 10, 2006 10:41 AM To: Steve Ebersole; 'emm...@hi...'; 'hib...@li...' Subject: Re: [Hibernate] Issue with pluggable functions Yes add back the old method signature We will remove it at a latter release Mark it as deprecated -----Original Message----- From: Steve Ebersole <ste...@jb...> To: Emmanuel Bernard <emm...@hi...>; Hibernate development <hib...@li...> Sent: Wed May 10 09:49:46 2006 Subject: RE: [Hibernate] Issue with pluggable functions Sorry, my fault. I forgot that we added that call to your stuff. =20 We really need this changed though to properly allow for (1) classic aggregation registration and (2) better user function registration.=20 =20 The other thing I could do is add back the old signature which would only be for your use, and which would not account for user-registered functions (planned feature). That work? =20 ________________________________ From: hib...@li... [mailto:hib...@li...] On Behalf Of Emmanuel Bernard Sent: Wednesday, May 10, 2006 9:05 AM To: Hibernate development Subject: [Hibernate] Issue with pluggable functions =20 public static String renderWhereStringTemplate(String sqlWhereString, Dialect dialect, SQLFunctionRegistry functionRegistry)=20 Breaks binary compatibility with Hibernate Annotations 3.2.0.CR1 |
Thanks for helping keep SourceForge clean.
X