hibernate-devel

[Hibernate] Delete bug (and fix)

[Andrea A. <aa...@li...>]

I've found a bug that causes a NPE in the Session.delete(String query)=20
implementation: if you pass a query that return no objects you end up
with an NPE. The incriminated code follows:

SessionImpl.java (line 1178)

public int delete(String query, Object[] values, Type[] types) throws=20
HibernateException, SQLException {

		if ( log.isTraceEnabled() ) {
			log.trace( "delete: " + query );
			if (values.length!=3D0)  log.trace( "parameters: " +=20
StringHelper.toString(values) );
		}

		List list =3D find(query, values, types);
		int size =3D list.size();
		for ( int i=3D0; i<size; i++ ) delete( list.get(i) );
		return size;
	}

The list.size() call fails if list is null... should look like:

	if(list !=3D null)  {
		int size =3D list.size();
		for ( int i=3D0; i<size; i++ ) delete( list.get(i) );
			return size;
	} else {
		return 0;
	}

Bye
Andrea

Re: [Hibernate] Delete bug (and fix)

[Gavin K. <ga...@ap...>]

The reason it doesn't check list!=null is that find() is never supposed to
return a null list.... How did you make that happen?? Do you have a
stacktrace, etc?


> I've found a bug that causes a NPE in the Session.delete(String query)
> implementation: if you pass a query that return no objects you end up
> with an NPE. The incriminated code follows:
>
> SessionImpl.java (line 1178)
>
> public int delete(String query, Object[] values, Type[] types) throws
> HibernateException, SQLException {
>
> if ( log.isTraceEnabled() ) {
> log.trace( "delete: " + query );
> if (values.length!=0)  log.trace( "parameters: " +
> StringHelper.toString(values) );
> }
>
> List list = find(query, values, types);
> int size = list.size();
> for ( int i=0; i<size; i++ ) delete( list.get(i) );
> return size;
> }
>
> The list.size() call fails if list is null... should look like:
>
> if(list != null)  {
> int size = list.size();
> for ( int i=0; i<size; i++ ) delete( list.get(i) );
> return size;
> } else {
> return 0;
> }
>
> Bye
> Andrea
>
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:
> Access Your PC Securely with GoToMyPC. Try Free Now
> https://www.gotomypc.com/s/OSND/DD
> _______________________________________________
> hibernate-devel mailing list
> hib...@li...
> https://lists.sourceforge.net/lists/listinfo/hibernate-devel

Re: [Hibernate] Delete bug (and fix)

[Andrea A. <aa...@li...>]

On Sunday 20 October 2002 11:49, Gavin King wrote:
> The reason it doesn't check list!=3Dnull is that find() is never supposed=
 to
> return a null list.... How did you make that happen?? Do you have a
> stacktrace, etc?

Well, I've already patched my local hybernate... anyway, can you
try session.delete("from x in class MyClass") where the associated
table is empty? This is how I generated this error, hope you can=20
reproduce it... ah, I'm working on a PostgreSQL db.
Andrea

Re: [Hibernate] Delete bug (and fix)

[Gavin K. <ga...@ap...>]

Andrea, I can't reproduce this. Can you please send me more detailed info.

> On Sunday 20 October 2002 11:49, Gavin King wrote:
> > The reason it doesn't check list!=null is that find() is never supposed
to
> > return a null list.... How did you make that happen?? Do you have a
> > stacktrace, etc?
>
> Well, I've already patched my local hybernate... anyway, can you
> try session.delete("from x in class MyClass") where the associated
> table is empty? This is how I generated this error, hope you can
> reproduce it... ah, I'm working on a PostgreSQL db.
> Andrea