From: Gavin_King/Cirrus%<CI...@ci...> - 2002-03-06 06:15:50
|
> i am writing a sap db dialect, (which is proving more painful than > originally expected :-)). > the default column name for the hilo generator is next. this is a reserved > word in sap db and cannot be used as a column name without being enclosed in > double quotes. Okay, we better change the default column name. *yick* this will affect people - thats kind of painful :( Make it next_hi that can't possibly be reserved anywhere. Thanks for helping out, Brad. If you send me your sourceforge username I can give you CVS access otherwise just mail me the dialect when you're done. |
From: Gavin_King/Cirrus%<CI...@ci...> - 2002-03-06 06:17:27
|
> i am writing a sap db dialect, (which is proving more painful than > originally expected :-)). > the default column name for the hilo generator is next. this is a reserved > word in sap db and cannot be used as a column name without being enclosed in > double quotes. Okay, we better change the default column name. *yick* this will affect people - thats kind of painful :( Make it next_hi that can't possibly be reserved anywhere. Thanks for helping out, Brad. If you send me your sourceforge username I can give you CVS access otherwise just mail me the dialect when you're done. |
From: Gavin_King/Cirrus%<CI...@ci...> - 2002-03-23 00:33:43
|
> i have just commited the sap db dialect to cvs. Excellent! Thanks Brad. :) > gavin, r u still happy for me to change the default column name for the > hilogenerator from next to next_hi (sap db gets upset when DBSchemaExport > tries to create the hibernate_unique_key table with a column name of next, > as it is a reserved word)? When we discussed this earlier other people seemed to prefer that we try using quoted "next". If we can get that working with all platforms its probably preferable. Can you try it out with SAP, please? > the test suite fails on testCreateUpdate due to the size of the double in > Foo.java. sap db seems to support to +1e-64, but Foo's double is set to > 1.33e-69, so the exponent seems to large to me. however the jdbc driver > appears to reduce it even more. i could only get to 1.33e-36 for the test > to be successful. i will send a message to the sapdb mailing list about > this. Interbase also has a problem like this, i think. I got round it by disabling part of the test. Thats a bit of a crude approach, I guess. Anyways, either change or disable the test if you like, whatever works.... Have you got the schema export working? Someone else reported that the "alter table add constraint" syntax is not supported by SAP DB so do we need to support alternative forms in Dialect? Does SAP support sequences or identity columns? |
From: Brad C. <bra...@wo...> - 2002-03-24 23:42:14
|
i just committed the changes to the hilogenerator for quoting the column name in all sql statements. i have used double quotes and the tests have passed both in sap db and oracle. if double quotes are illegal in one of the other supported rdbms' perhaps the quote used could be made dialect specific. to get around the double problem, i reduced the size of the value that the double is set to in Foo.java. i have set alter table support to false, to get around the syntax problems with the alter table statements generated in the schema export. this is a lower priority for me at the moment than some other things, so i won't get to look at this for perhaps a week or so. sequences are supported. i will add support for them to the dialect today/tommorrow. brad ----- Original Message ----- From: <Gavin_King/Cirrus%CI...@ci...> To: "Brad Clow" <bra...@wo...> Cc: <hib...@li...> Sent: Saturday, March 23, 2002 10:21 AM Subject: Re: [Hibernate-devel] SAP DB dialect > > > i have just commited the sap db dialect to cvs. > > Excellent! Thanks Brad. :) > > > gavin, r u still happy for me to change the default column name for the > > hilogenerator from next to next_hi (sap db gets upset when DBSchemaExport > > tries to create the hibernate_unique_key table with a column name of > next, > > as it is a reserved word)? > > When we discussed this earlier other people seemed to prefer that we try > using quoted "next". If we can get that working with all platforms its > probably preferable. Can you try it out with SAP, please? > > > the test suite fails on testCreateUpdate due to the size of the double in > > Foo.java. sap db seems to support to +1e-64, but Foo's double is set to > > 1.33e-69, so the exponent seems to large to me. however the jdbc driver > > appears to reduce it even more. i could only get to 1.33e-36 for the > test > > to be successful. i will send a message to the sapdb mailing list about > > this. > > Interbase also has a problem like this, i think. I got round it by > disabling > part of the test. Thats a bit of a crude approach, I guess. Anyways, either > change or disable the test if you like, whatever works.... > > Have you got the schema export working? Someone else reported that the > "alter table add constraint" syntax is not supported by SAP DB so do > we need to support alternative forms in Dialect? > > Does SAP support sequences or identity columns? > > > |
From: Doug C. <de...@fl...> - 2002-03-06 16:46:29
|
>> the default column name for the hilo generator is next. this is a reserved >> word in sap db and cannot be used as a column name without being enclosed in >> double quotes. > Okay, we better change the default column name. *yick* this will affect > people - thats kind of painful :( I have two alternate suggestions: - make it dialect specific, or - make it "next" (with quotes) These should be backward compatible. e |