[Hexedit-dev] patches

[Ben H. <bh...@al...>]

What version of CarbonLib are you supporting for HexEdit?  I'd 
suggest sticking with the latest, since that is easiest. There's a 
PPC version anyway.

If we want to have 1.3 as minimum, here is the patch to properly 
respect the dock. (currently HexEdit opens new windows under it) Also 
included is my fix for my own feature request 496196.

(give me access to CVS and i could submit these meself - acct benh57)

Index: hexedit/Source/EditWindow.c
===================================================================
RCS file: /cvsroot/hexedit/hexedit/Source/EditWindow.c,v
retrieving revision 1.42
diff -c -2 -r1.42 EditWindow.c
*** hexedit/Source/EditWindow.c	19 Nov 2001 01:20:31 -0000	1.42
--- hexedit/Source/EditWindow.c	14 Feb 2002 07:16:05 -0000
***************
*** 538,541 ****
--- 538,547 ----
  	SetPortWindowPort( theWin );

+ #if TARGET_API_MAC_CARBON
+     // benh57 - we need to check the dock when creating new 
windows, since it can move.
+     // This function is in CarbonLib 1.3. or higher.
+     GetAvailableWindowPositioningBounds(GetMainDevice(), &r);  
+     g.maxHeight = r.bottom;
+ #endif
  	dWin->offscreen = _newCOffScreen( kHexWindowWidth - 
kSBarSize, g.maxHeight - kHeaderHeight );	// LR: 1.7 - areas 
for scroll bar & header not needed!
  	if( !dWin->offscreen )
***************
*** 593,600 ****
   #if TARGET_API_MAC_CARBON	// LR: v1.6
   {
!	BitMap qdScreenBits;
!
!	GetQDGlobalsScreenBits( &qdScreenBits );
!	g.maxHeight = qdScreenBits.bounds.bottom - 
qdScreenBits.bounds.top - 24;
   }
   #else
--- 599,610 ----
   #if TARGET_API_MAC_CARBON	// LR: v1.6
   {
! //	BitMap qdScreenBits;
! //	GetQDGlobalsScreenBits( &qdScreenBits );
! //	g.maxHeight = qdScreenBits.bounds.bottom - 
qdScreenBits.bounds.top - 24;
!
! // benh57 - Respect the dock/menubar, not the screen. This function 
is in CarbonLib 1.3. or higher.
!     Rect r;
!     GetAvailableWindowPositioningBounds(GetMainDevice(), &r);  
!     g.maxHeight = r.bottom;
   }
   #else
***************
*** 781,784 ****
--- 791,795 ----
  	NavGetDefaultDialogOptions( &dialogOptions );
  	dialogOptions.dialogOptionFlags |= 
kNavNoTypePopup+kNavAllowInvisibleFiles; // BB: allow invisible files 
- fixes bug #425256
+	dialogOptions.dialogOptionFlags |= 
kNavSupportPackages+kNavAllowOpenPackages;   // benh57: allow 
browsing into packages. (496196)
  	error = NavGetFile( NULL, &reply, &dialogOptions, eventProc, 
previewProc, filterProc, openTypeList, kNavOpenDialogType);
  	if( reply.validRecord || !error )

-- 
http://homepage.mac.com/bhines/