#2631 Replace SynEdit syntax highlighter with DScintilla

[Anonymous]

Originally created by: a...@anse.de
Originally owned by: a...@anse.de

What is the problem that needs to be solved (required)?

SynEdit is no longer maintained, since several years. Bugs are therefore seen but stay unsolved.

What is the idea in abstract terms (optional)?

Use Scintilla, a free syntax editor, which offers even more than SynEdit, like code folding. The license allows it to be included in free projects: http://www.scintilla.org/License.txt

[Anonymous]

Originally posted by: a...@anse.de

Too much effort I guess. Scintilla is written in C and needs a Delphi wrapper first. I'll prefer leaving my fingers from that stuff.

Status: WontFix

[Anonymous]

Originally posted by: a...@anse.de

Delphi wrapper for Scintilla: https://code.google.com/p/dscintilla/

Bad news from http://en.wikipedia.org/wiki/Scintilla_%28editing_component%29 , which will stop me from putting that into HeidiSQL:
"... Furthermore, the regular expression search implementation is rudimentary, and the numerous shortcomings have been known for years and affect the performance of dependent editor projects (e.g. Notepad++)"

Summary: Replace SynEdit syntax highlighter with DScintilla

[Anonymous]

Originally posted by: wyatto... (code.google.com)@gmail.com

Why don't you use any one of the many Regex engine on the text of the document. That is, why depend on Regex from inside scintilla when you can use an external regex engine: http://www.regular-expressions.info/delphi.html

Does that make sense?

[Anonymous]

Originally posted by: a...@anse.de

HeidiSQLs search and replace dialog makes use of Synedit's Delphi approach for search dialogs, including regex functionality. That's a powerful thing which is not supported by scintilla. Then, there is more Synedit stuff baken into HeidiSQL, fx the myriad of highlighting preferences. Now, if Scintilla does not provide this and that, I see no advantage in migrating away from Synedit.

[Anonymous]

Originally posted by: wyatto... (code.google.com)@gmail.com

The point is that it provides all the functionality HeidiSQL currently uses, however it does it in different ways. Now, I suppose it would be a lot of work to switch from something that has all this stuff "baked in" to something that you have to put a bit of work into.

But you also have to consider the upsides Scintilla (stability, wide use, speed, active development) vs. the downsides of Synedit (the most critical one that I'm aware of was the access violation crash, but I'm sure there are others).

Although this is easy for me to say. I'm not the one that will do the work of switching from Synedit to Scintilla.

[Anonymous]

Originally posted by: a...@anse.de

> the most critical one that I'm aware of was the access violation crash, but I'm sure there are others

Not that I know of. At least there are very few SynEdit issues in the tracker.

Yes, I'm comparing pros and cons of the topic. And I must say the effort and missing things weigh up the advantages over SynEdit.

[Anonymous]

Originally posted by: a...@anse.de

Issue 3296 has been merged into this issue.

[Anonymous]

Originally posted by: a...@anse.de

Issue 3296 has been merged into this issue.

[Anonymous]

Originally posted by: a...@anse.de

Issue 3296 has been merged into this issue.