Re: [Hcfr-developer] ccss (was Intro)

[Ian <pb...@be...>]

  A ccss sample file is identified either by it's filename or by the 
more friendly textual description that's embedded in the file itself, 
which will say something like "LCD WIDE GAMUT IPS". spectralType is just 
this textual description, which is always meant to be the spectral type 
of the device. I should have called it "ccssDescription" or something 
similar.

I agree, it may be worth splitting the code into a separate class. I'll 
have a look into it...

Ian

On 16/04/2012 09:13, John Adcock wrote:
> Ian
>
> Great! That saves me from doing it....
>
> It sounds like your approach is similar to how I would have done it.
>
> A few comments though.
>
> Probably worth pointing out that ArgyllMeterWrapper code is cross platform so care is need to avoid platform specific stuff.  I think it may be worth splitting out the ccss file handling code into a seperate class.  Also we should try and maintain the ability to localize, so ideally we shouldn't be exposing stuff like SpectralType as strings.
>
> I'm not yet 100% sure I've got my head round the meaning of some of the header parts to the ccss and how that relates to how we should match them in the UI, but we can always work on that later.
>
> John
>
>
>
>
>
> --- snip ---
> and implemented .ccss
> spectral sample calibration files. These are important to get any degree
> of accuracy on the i1d3. X-rite supply 4 generic spectral samples in
> .EDR format that can be converted and installed using i1d3ccss. The
> implementation pulls the files from the installed location and loads the
> selected one into the device when CArgyllSensor::Init() is called. The
> implementation itself is in the ArgyllMeterWrapper class (see below)
> with the addition of a combox box field to the CArgyllSensorPropPage
> dialog box.
> --- snip ---