|
From: John A. <jo...@th...> - 2012-04-16 08:13:01
|
Ian Great! That saves me from doing it.... It sounds like your approach is similar to how I would have done it. A few comments though. Probably worth pointing out that ArgyllMeterWrapper code is cross platform so care is need to avoid platform specific stuff. I think it may be worth splitting out the ccss file handling code into a seperate class. Also we should try and maintain the ability to localize, so ideally we shouldn't be exposing stuff like SpectralType as strings. I'm not yet 100% sure I've got my head round the meaning of some of the header parts to the ccss and how that relates to how we should match them in the UI, but we can always work on that later. John --- snip --- and implemented .ccss spectral sample calibration files. These are important to get any degree of accuracy on the i1d3. X-rite supply 4 generic spectral samples in .EDR format that can be converted and installed using i1d3ccss. The implementation pulls the files from the installed location and loads the selected one into the device when CArgyllSensor::Init() is called. The implementation itself is in the ArgyllMeterWrapper class (see below) with the addition of a combox box field to the CArgyllSensorPropPage dialog box. --- snip --- |