[Hamlib-developer] [Hamlib/Hamlib] f3db09: fix(rigctld): quiesce stream feeders before rig close

[David C. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/Hamlib/Hamlib
  Commit: f3db0910413a7783af0c2a0a8f95bad2ffc45fb7
      https://github.com/Hamlib/Hamlib/commit/f3db0910413a7783af0c2a0a8f95bad2ffc45fb7
  Author: David Christle <dch...@us...>
  Date:   2026-09-21 (Mon, 21 Sep 2026)

  Changed paths:
    M test/test_netrigctl_stream.c
    M test/test_rigctld_stream.c
    M tests/rigctld.c
    M tests/rigctld_stream.c
    M tests/rigctld_stream.h

  Log Message:
  -----------
  fix(rigctld): quiesce stream feeders before rig close

rig_close() frees backend stream handles while rigctld feeders may still use them, allowing an idle client disconnect to trigger a use-after-free.

Centralize rig shutdown behind registry-wide feeder teardown and close client-owned streams before the last-client idle transition. Add registry and end-to-end regression coverage for abrupt disconnect and reopen.


  Commit: 96ba014a9b0f208f5ba0e8b49c06c0dac6430ed7
      https://github.com/Hamlib/Hamlib/commit/96ba014a9b0f208f5ba0e8b49c06c0dac6430ed7
  Author: David Christle <dch...@us...>
  Date:   2026-09-21 (Mon, 21 Sep 2026)

  Changed paths:
    M test/test_rigctld_commands.c
    M tests/rigctl_parse.c

  Log Message:
  -----------
  fix(rigctld): guard stream handles during control calls

Feeder auto-close can free a backend stream after a registry lookup unlocks but before the public API acquires its lifetime guard. Keep the registry lock through pause, resume, and drain calls, and verify the invariant with backend probe hooks.


  Commit: 9e224cc54a9bc04f8bce8afe076e4fd2ec152995
      https://github.com/Hamlib/Hamlib/commit/9e224cc54a9bc04f8bce8afe076e4fd2ec152995
  Author: David Christle <dch...@us...>
  Date:   2026-09-21 (Mon, 21 Sep 2026)

  Changed paths:
    M tests/rigctld.c

  Log Message:
  -----------
  fix(rigctld): clean up client thread launch failures

Destroy detached-thread attributes after every initialized launch attempt. Close the accepted socket and release its connection data when attribute setup or pthread_create fails, using the portable socket helper on all early rejection paths.


Compare: https://github.com/Hamlib/Hamlib/compare/79b5e29d8d90...9e224cc54a9b

To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications