[Hamlib-developer] [Hamlib/Hamlib] 364375: rig_set_level: fix NULL pointer dereference on RIG...

[Nate B. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/Hamlib/Hamlib
  Commit: 3643758ace123fad981541af04acffb6fdef35ac
      https://github.com/Hamlib/Hamlib/commit/3643758ace123fad981541af04acffb6fdef35ac
  Author: Øystein Hårberg <oeh...@gm...>
  Date:   2026-08-11 (Tue, 11 Aug 2026)

  Changed paths:
    M src/settings.c

  Log Message:
  -----------
  rig_set_level: fix NULL pointer dereference on RIG_LEVEL_KEYSPD

rig_set_level() unconditionally calls morse_data_handler_set_keyspd()
whenever a backend's RIG_LEVEL_KEYSPD is set, dereferencing
STATE(rig)->morse_data_handler_priv_data with no NULL check. That
pointer is only ever allocated by morse_data_handler_start() (the
send_morse()/morse-over-data-channel path), so any backend supporting
KEYSPD segfaults the caller on a plain rig_set_level(...,
RIG_LEVEL_KEYSPD, ...) if that subsystem was never started - the common
case for a simple "rigctl ... L KEYSPD nn" call.

Found while testing a new backend implementing RIG_LEVEL_KEYSPD,
confirmed via a catchsegv backtrace pointing at
morse_data_handler_set_keyspd <- rig_set_level.

Co-Authored-By: Claude Sonnet 5 <no...@an...>


  Commit: f46d227bd46e96331fd51004aa7a842ae6803d8f
      https://github.com/Hamlib/Hamlib/commit/f46d227bd46e96331fd51004aa7a842ae6803d8f
  Author: Nate Bargmann <n0...@n0...>
  Date:   2026-09-19 (Sat, 19 Sep 2026)

  Changed paths:
    M src/settings.c

  Log Message:
  -----------
  Merge GitHub PR #2145


Compare: https://github.com/Hamlib/Hamlib/compare/b32c766782d1...f46d227bd46e

To unsubscribe from these emails, change your notification settings at https://github.com/Hamlib/Hamlib/settings/notifications