Re: [Gwc-general] Encoding to MP3 problem, byte swapping occurs

[Alister H. <ali...@gm...>]

Alister Hood wrote, On 25/09/14 19:44:
> Hi again,
>
>
> John Cirillo wrote, On 25/09/14 15:40:
>> ...
>> There is something new in 0.21-19 that I'm not sure I understand.  
>> After I get the "encode to filename" dialog and click OK, I get 
>> another box that says to enter the track name.  I didn't know what to 
>> put so I just put the number 1 and it took it, but the box didn't 
>> completely clear and there is no encoding progress bar.
>> I don't know what it did with that track name?  It didn't end up in 
>> the id3 tag info.
> Good spotting.  If you use the "Simple encode selection as mp3" it 
> ends up in the id3 tag.  I hadn't got around to comparing the "old" 
> and "new" encode functions yet to look for any other differences like 
> this - I'll do so now.
> If you're building and using your own copy of gwc anyway, would you 
> mind using my version on github, instead of just this patch? I believe 
> it is less buggy, but testing is good!  BTW I haven't had a chance to 
> attempt the last changes needed to finish porting to plain gtk, but 
> hopefully I will soon.
It turns out that the track name was simply unimplemented for "Save 
selection as..." (not surprisingly, given that "Save selection as..." 
wasn't working at all in 0.21-19).  It was an easy fix though.
But I found the fix for "Save selection as..." using the "new" 
start_encode() function is also easy - it just needed this line copied 
into the right place where the mp3 and ogg options are set:

options[optcnt] = pipe_name ; /* named pipe */