Re: [Gwc-general] Invalid cdrdao toc file

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

On 08/04/12 23:36, jeff welty wrote:
> Hi Brian,
>
> Thanks very much for the more detailed info. I was able to reproduce the
> problem, and it is one nasty bug. I guess everyone must've switched over
> to using the song marker pairs. BTW, the marker pairs idea allows you to
> have gaps between songs, some lead-in audio (like when the the needle
> hits the vinyl ;-) ), and some trail out audio. It gives you more
> control on what segments of audio you want to appear on the CD tracks.
>
> Another bit of important trivia, audio tracks must be integral numbers
> of audio blocks, which are 588 samples in length, so if you are doing
> math with song markers, you'll find small differences because GWC will
> create the cdrdao file with the track lengths to the nearest audio block.
>
> I have patched up the markers.c source code, and it is attached.

Sorry to bring bad news, Jeff, but I have just built and tested your new 
source module. It looks to me as if you have nearly fixed the bug, but 
there is still a bit more to do.

It seems to me that you haven't disabled the marker pair "track 
separator logic" and so the toc is not inclusive of every sample...

i.e. start_track_n+1 != (start_track_n + length_track_n)

Here is the toc built by your new code using the same wav and .gwc file 
as my test files below. You should compare it to the toc I built by hand 
to see what I think ought to be the "right answer".

I won't start debugging your code unless you are too busy to do it 
yourself - I am sure you are so familiar with it you'll come up with a 
fix in a fraction of the time it would take me!

Regards,

Brian
>
> I'll see if I can get hold of the ubuntu maintainers, they'll really
> want to have this bugfix!
>
> Thank you again!
> Jeff
>
> ------------------------------------------------------------------------
> *From:* Brian Burch <br...@pi...>
> *To:* "gwc...@li..."
> <gwc...@li...>
> *Sent:* Sunday, April 8, 2012 1:16 PM
> *Subject:* Re: [Gwc-general] Invalid cdrdao toc file
>
> On 08/04/12 03:19, jeff welty wrote:
>  > Hi Brian,
>
> Hi Jeff,
>
> I'm really pleased that you picked up my question so quickly and I
> really appreciate you helping me.
>
>  > Literally nothing has changed in the code that handles the song markers
>  > and creates the cdrdao toc file since before version 0.21-10.
>
> I wish I had noticed which version of gwc was running the last time I
> used it successfully. If it turns out to be important, I will dig
> through my backups to identify it.
>
> However, I'm fairly confident ubuntu studio was offering something older
> than 0.21-10 in its repository about 2 years ago.
>
>
>  > It sounds to me like you may have inadvertantly used the
>  > "Create cdrdao toc file, using marker pairs, As..."
>  > version of creating the toc file? That causes the first track to start
>  > not at sample 0, but rather starts the first track at the position of
>  > the first song marker.
>
> Yes, I thought of that too because I was intrigued by the menu items
> that I didn't recognise from the previous version that I used.
>
> I am sure I didn't make that mistake, but to be certain I started from
> scratch (see below).
>
>  > I am pretty sure you did find a bug though, I'll bet you had an odd
>  > number of song markers, and gwc read whatever garbage was on the stack
>  > to find the end position for the last track.
>  > Can you double check that gwc does create a valid toc file for your
>  > project with the "Create cdrdao toc file As..." option, just in case you
>  > did click the wrong one?
>
> I created a fresh directory and copied a single, large wav file into it
> (i.e. there were no pre-existing blah.wav.gwc or blah.toc files. I split
> it arbitrarily into three tracks.
>
> Here is the cdrdao.toc created by gwc:
>
> CD_TEXT {
> LANGUAGE_MAP {
> 0: EN
> }
> LANGUAGE 0 {
> TITLE "The Doors"
> MESSAGE "Brians clean test"
> }
> }
> TRACK AUDIO
> CD_TEXT {
> LANGUAGE 0 {
> TITLE "part 1"
> MESSAGE ""
> }
> }
> FILE "/home/brian/gwc-test/export.wav" 38342565 28204595
> TRACK AUDIO
> CD_TEXT {
> LANGUAGE 0 {
> TITLE "part 2"
> MESSAGE ""
> }
> }
> FILE "/home/brian/gwc-test/export.wav" 66547236 50606219
> TRACK AUDIO
> CD_TEXT {
> LANGUAGE 0 {
> TITLE "part 3"
> MESSAGE ""
> }
> }
> FILE "/home/brian/gwc-test/export.wav" 0 117153707
>
>
> ... and here is the "correct" version that I created from the
> information available in the gwc window using the same song markers:
>
> CD_TEXT {
> LANGUAGE_MAP {
> 0: EN
> }
> LANGUAGE 0 {
> TITLE "The Doors"
> MESSAGE "Brians clean test, manual assignment of boundaries"
> }
> }
> TRACK AUDIO
> CD_TEXT {
> LANGUAGE 0 {
> TITLE "part 1"
> MESSAGE ""
> }
> }
> FILE "/home/brian/gwc-test/export.wav" 0 38342566
> TRACK AUDIO
> CD_TEXT {
> LANGUAGE 0 {
> TITLE "part 2"
> MESSAGE ""
> }
> }
> FILE "/home/brian/gwc-test/export.wav" 38342566 28204672
> TRACK AUDIO
> CD_TEXT {
> LANGUAGE 0 {
> TITLE "part 3"
> MESSAGE ""
> }
> }
> FILE "/home/brian/gwc-test/export.wav" 66547238 50606490
> // total number of samples calculated: 117153728
> // total number of samples from gwc : 117153727
>
>
> Obviously, the first track ought to start with sample zero and it
> doesn't. In fact, if you look carefully it seems "first" track has been
> built with the start and length values required to define the real
> SECOND track!
>
> The "second" track carries the start and length of the real THIRD track.
>
> The "third" track starts with sample zero, and its length is /nearly/
> the same as the number of samples in the entire file.
>
> I definitely added song markers, NOT song marker pairs. I definitely
> saved the toc with the correct option, not trying to use marker pairs.
>
> However, just in case it is significant, I used VIEW -> select all
> before creating the toc file. My previous version required EDIT ->
> select all, but this no longer exists.
>
> I would appreciate your thoughts on my latest experiment and evidence.
> If you think it is important, I will find out which version of gwc last
> worked OK for me using the same procedure.
>
> n.b. I do NOT place a song marker before the first sample... perhaps I
> should try that as an experiment?
>
>  > Thanks very much for the report, regardless. It's good to know GWC is
>  > still getting some use...
>
> I think it is a brilliant tool and wouldn't use anything else to clean
> up a noisy vinyl recording. I'm very pleased someone is still watching
> over it.
>
> Regards,
>
> Brian
>
>  > Jeff
>  >
>  > ------------------------------------------------------------------------
>  > *From:* Brian Burch <br...@pi... <mailto:br...@pi...>>
>  > *To:* gwc...@li...
> <mailto:gwc...@li...>
>  > *Sent:* Thursday, April 5, 2012 9:34 AM
>  > *Subject:* [Gwc-general] Invalid cdrdao toc file
>  >
>  > I am using GWC 0.21-16, which is currently shipped with the ubuntu
>  > studio 12.04 precise pangolin beta 2. It is also the current version
>  > with my production ubuntu studio 11.10 system.
>  >
>  > It isn't strictly relevant, but I convert vinyl to digital using an
>  > Edirol FA-66 firewire device controlled by jackd and captured by Ardour.
>  >
>  > I use Ardour to export a single wav file for the entire vinyl album and
>  > then use gwc to clean up the recording.
>  >
>  > When I have a wav file that I like, I then manually mark the boundary of
>  > each track with "Markers -> Add Song Marker". Finally, I "View ->
>  > SelectAll" and then "File -> Create cdrdao toc file As...".
>  >
>  > I manually fill in the album and track names on the toc dialogue and
>  > save the file. I write a new CD with "cdrdao --speed 4 export.toc". This
>  > is a procedure I've been following for several years without any
> problems.
>  >
>  > However, since I upgraded gwc to 0.21-16, cdrdao has complained about
>  > the toc files and refused to write the cd as follows:
>  >
>  > brian@schizo:~/WeatherReport-sportinLife/export$ cdrdao write --speed 4
>  > export.toc
>  > Cdrdao version 1.2.3 - (C) Andreas Mueller <an...@da...
> <mailto:an...@da...>
>  > <mailto:an...@da... <mailto:an...@da...>>>
>  > ERROR: Track 7: Requested length (89737555 + 12992447 samples) exceeds
>  > length of audio file
>  > "/home/brian/WeatherReport-sportinLife/export/export.wav" (102729733
>  > samples at offset 0).
>  > ERROR: The toc check function detected at least one warning.
>  > ERROR: If you record this toc the resulting CD might be unusable
>  > ERROR: or the recording process might abort with error.
>  > ERROR: Use option --force to ignore the warnings.
>  > ERROR: Toc file "export.toc" is inconsistent.
>  >
>  > The toc file is fairly badly wrong - the first track does not even start
>  > with sample number zero!
>  >
>  > I took a copy of the bad toc file and manually edited all the track
>  > start and length sample counters. I took the actual boundaries by
>  > displaying the sample counters for each of the song markers displayed by
>  > gwc, so we were working off the same wav file and analysis. My manual
>  > sample counters were very different to those automatically generated
> by gwc.
>  >
>  > I've googled, but not found anything relevant. Am I using the
>  > appropriate dialogue to create my toc file on this release of gwc (i.e.
>  > this is a user error), or does this sound like a bug? (I notice you've
>  > added new toc file features in recent releases, so perhaps this is
>  > collateral damage.)
>  >
>  > I don't know whether your mailing list strips attachments, so I won't
>  > send the two files at this time. I'm happy to send them in-line if
>  > anyone feels they would help in diagnosis.
>  >
>  > Obviously this isn't urgent for me because I have a tedious but viable
>  > bypass for the problem. However, this version of gwc is being pushed out
>  > as 0.21.16~dfsg-3build (precise) and 0.21.16~dfsg-3 (oneiric) from the
>  > ubuntu repositories, so it has a wide exposure!
>  >
>  > Regards,
>  >
>  > Brian Burch
>  >
>  >
>  >
> ------------------------------------------------------------------------------
>  > Better than sec? Nothing is better than sec when it comes to
>  > monitoring Big Data applications. Try Boundary one-second
>  > resolution app monitoring today. Free.
>  > http://p.sf.net/sfu/Boundary-dev2dev
>  > _______________________________________________
>  > Gwc-general mailing list
>  > Gwc...@li...
> <mailto:Gwc...@li...>
> <mailto:Gwc...@li...
> <mailto:Gwc...@li...>>
>  > https://lists.sourceforge.net/lists/listinfo/gwc-general
>  >
>  >
>
>
> ------------------------------------------------------------------------------
> For Developers, A Lot Can Happen In A Second.
> Boundary is the first to Know...and Tell You.
> Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
> http://p.sf.net/sfu/Boundary-d2dvs2
> _______________________________________________
> Gwc-general mailing list
> Gwc...@li... <mailto:Gwc...@li...>
> https://lists.sourceforge.net/lists/listinfo/gwc-general
>
>